Skip to content

Conversation

SanjaySiddharth
Copy link

What it Does

  • Closes IMPROVE - Filter OdometerView by Vehicle #350
  • Added a filter in OdometerView which shows the readings of either all the vehicles(default) or any one selected vehicle
  • Fixed typo in a commented line
  • Added 3rd car and another reading to the preview in OdometerView

How I Tested

  • Run the application
  • Add three vehicles from the Settings tab
  • Navigate to Odometer screen and create some readings for each vehicle
  • Click on the filter button in the toolbar (prior to the plus sign(+))
  • Choose the vehicle you want to filter on . By default it shows all the vehicles.
  • Repeat the above step, but select All Vehicles to ensure all readings reappear.

Screenshot

1
2
3

… the vehicles(default) or any one selected vehicle
@mikaelacaron
Copy link
Owner

Thank for the contribution! I'll try to review this soon

Copy link

@ClarkLiam ClarkLiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes seem to add a working filter system and fixes typos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IMPROVE - Filter OdometerView by Vehicle
3 participants