Upgrade Tokio to v1.x and Hyper to v0.14 #3804
Merged
+320
−457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tromp
reviewed
Mar 3, 2025
| let listener = TcpListener::bind(&addr).await.expect("failed to bind"); | ||
|
|
||
| let tls_stream = async_stream::stream! { | ||
| loop { |
There was a problem hiding this comment.
Why does this need a loop that was not needed before?
There was a problem hiding this comment.
Without the loop it would handle a single connection before stopping, this is the common pattern in this particular version of hyper (and beyond, I think, though we'll get to updating hyper to the latest in a future PR). An example here https://github.com/hs-CN/async-rustls-stream/blob/ec4298493353d3fae6f86e106d07543b9f1bea56/examples/server_client.rs#L38
tromp
reviewed
Mar 3, 2025
| } | ||
| } | ||
| } | ||
| .for_each(move |socket| { |
There was a problem hiding this comment.
I can't believe how bad git is at diffing this change. It looks like it matches perfectly from the old line 611 vs this line 619 down, but git manages to mismatch it all...
tromp
approved these changes
Mar 3, 2025
bayk
pushed a commit
to mwcproject/mwc-node
that referenced
this pull request
Jul 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates several long-overdue dependencies:
Tokio: upgraded to version 1.x
Hyper: upgraded to version 0.14
Hyper-rustls: upgrade to 0.23
Tokio-util: upgrade version 0.7
Rustls: Added as an explicit dependency at version 0.20
HTTP Connector Fix: Modified the HTTP connector to allow both HTTP and HTTPS connections for testing purposes.
This will likely require extensive testing once reviewed and merged into master. I'll likely move onto upgrading hyper once these changes are sufficiently verified.