Skip to content

Commit b423647

Browse files
Merge pull request #23 from mindfiredigital/dev
Release new bug fixes
2 parents 1a816d5 + 5c2c740 commit b423647

File tree

6 files changed

+65
-9
lines changed

6 files changed

+65
-9
lines changed

packages/document-editor-angular/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,7 @@
5656
"@angular/common": "^19.1.0",
5757
"@angular/compiler": "^19.1.0",
5858
"@angular/core": "^19.1.0",
59+
"@angular/elements": "^19.2.7",
5960
"@angular/forms": "^19.1.0",
6061
"@angular/material": "^19.1.4",
6162
"@angular/platform-browser": "^19.1.0",

packages/document-editor-angular/projects/my-canvas-lib/src/lib/components/color-palette/color-palette.component.html

Lines changed: 20 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,12 +25,29 @@
2525
</mat-menu>
2626
</div>
2727

28-
<app-color-picker
28+
<!--
29+
The `app-color-picker` component is currently commented out because:
30+
1. Its input properties (`colorPickerAnchor`, `color`, `feature`) and output property (`close`)
31+
are not defined or implemented in the parent component.
32+
2. If this component has a valid use case, it requires further discussion and implementation
33+
in the child component (`ColorPickerComponent`) to ensure proper functionality.
34+
3. Until the requirements and design are clarified, the component remains inactive to avoid
35+
runtime errors or unused code.
36+
37+
TODO: Discuss with the team to determine if this component is needed and implement the necessary
38+
logic in both the parent and child components if required.
39+
-->
40+
<!-- <app-color-picker
2941
*ngIf="colorPickerAnchor"
3042
[colorPickerAnchor]="colorPickerAnchor"
3143
[color]="definedColor"
3244
[feature]="feature"
3345
(close)="colorPickerHandleClose()"
34-
></app-color-picker>
46+
></app-color-picker> -->
3547
<!-- Manual trigger -->
36-
<button mat-button [matMenuTriggerFor]="popover" #menuTrigger="matMenuTrigger" hidden></button>
48+
<button
49+
mat-button
50+
[matMenuTriggerFor]="popover"
51+
#menuTrigger="matMenuTrigger"
52+
hidden
53+
></button>

packages/document-editor-angular/projects/my-canvas-lib/src/lib/components/color-palette/color-palette.component.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@ import { ColorPickerComponent } from '../color-picker/color-picker.component';
3434
export class ColorPaletteComponent implements AfterViewInit {
3535
@ViewChild(MatMenuTrigger, { static: false }) menuTrigger!: MatMenuTrigger;
3636

37-
@Input() anchorEl!: HTMLElement | null;
3837
@Input() definedColor!: string;
3938
@Input() feature!: string;
4039
@Output() close = new EventEmitter<void>();

packages/document-editor-angular/projects/my-canvas-lib/src/lib/components/font-color-button/font-color-button.component.html

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55

66
<app-color-palette
77
*ngIf="anchorEl"
8-
[anchorEl]="anchorEl.nativeElement"
98
(close)="handleClose()"
109
[feature]="Color.COLOR"
1110
></app-color-palette>

packages/document-editor-angular/projects/my-canvas-lib/src/lib/components/highlight-text/highlight-text.component.html

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,17 @@
22
<fa-icon [icon]="faHighlighter"></fa-icon>
33
</button>
44

5-
<app-color-palette
5+
<!--
6+
[anchorEl]="anchorEl.nativeElement"
7+
The `anchorEl` input property is currently removed out because:
8+
1. It is not defined or implemented in the `app-color-palette` component.
9+
2. Its purpose and usage are unclear, and it may be unnecessary or obsolete.
10+
3. If this property is required for positioning or functionality, it needs clarification
11+
and implementation in both the parent and child components.
12+
-->
13+
<app-color-palette
614
*ngIf="anchorEl"
7-
[anchorEl]="anchorEl.nativeElement"
815
(close)="handleClose()"
9-
[feature]="Color.HIGHLIGHT">
16+
[feature]="Color.HIGHLIGHT"
17+
>
1018
</app-color-palette>

packages/document-editor-react/package.json

Lines changed: 33 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,38 @@
1111
"registry": "https://registry.npmjs.org/",
1212
"access": "public"
1313
},
14+
"keywords": [
15+
"text-editor",
16+
"document",
17+
"react",
18+
"googledocs",
19+
"document-editor",
20+
"html5canvas",
21+
"google-doc-clone",
22+
"multi-page-viewer",
23+
"typescript",
24+
"framework",
25+
"cli",
26+
"javascript",
27+
"npm-package",
28+
"no-code",
29+
"low-code",
30+
"component-based",
31+
"responsive-design",
32+
"components",
33+
"component",
34+
"react-component",
35+
"ui",
36+
"vue",
37+
"angular",
38+
"modern",
39+
"plugin",
40+
"eslint",
41+
"web",
42+
"webpack",
43+
"css",
44+
"html"
45+
],
1446
"files": [
1547
"dist"
1648
],
@@ -69,7 +101,7 @@
69101
"dependencies": {
70102
"@emotion/react": "^11.11.1",
71103
"@emotion/styled": "^11.11.0",
72-
"@mindfiredigital/canvas-editor": "^1.0.5",
104+
"@mindfiredigital/canvas-editor": "^1.2.1",
73105
"@mui/icons-material": "^5.11.16",
74106
"@mui/material": "^5.13.5",
75107
"@r2wc/react-to-web-component": "^2.0.3",

0 commit comments

Comments
 (0)