Skip to content
This repository was archived by the owner on Dec 11, 2024. It is now read-only.

Conversation

onimsha
Copy link

@onimsha onimsha commented Sep 6, 2024

Signed-off-by: Alex Co alex.tuan@mindvalley.com

Description

[Provide a brief description of the changes in this PR]

How Has This Been Tested?

[Describe the tests you ran to verify your changes]

Accepted Risk

[Any know risks or failure modes to point out to reviewers]

Related Issue(s)

[If applicable, link to the issue(s) this PR addresses]

Checklist:

  • All of the automated tests pass
  • All PR comments are addressed and marked resolved
  • If there are migrations, they have been rebased to latest main
  • If there are new dependencies, they are added to the requirements
  • If there are new environment variables, they are added to all of the deployment methods
  • If there are new APIs that don't require auth, they are added to PUBLIC_ENDPOINT_SPECS
  • Docker images build and basic functionalities work
  • Author has done a final read through of the PR right before merge

Signed-off-by: Alex Co <alex.tuan@mindvalley.com>
Signed-off-by: Alex Co <alex.tuan@mindvalley.com>
Signed-off-by: Alex Co <alex.tuan@mindvalley.com>
Signed-off-by: Alex Co <alex.tuan@mindvalley.com>
Signed-off-by: Alex Co <alex.tuan@mindvalley.com>
Signed-off-by: Alex Co <alex.tuan@mindvalley.com>
@onimsha onimsha merged commit df55d37 into main Sep 6, 2024
2 of 4 checks passed
@onimsha onimsha deleted the chore/optimize-model-build-workflow branch September 6, 2024 12:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant