From 80fd7207a0a48793f38867682ff8aea166b4f72d Mon Sep 17 00:00:00 2001 From: Michele Bastione Date: Wed, 10 Sep 2025 23:55:13 +0200 Subject: [PATCH] Fixes an oversight in PR 870 due to which DateOnly values were calculated but not mapped --- src/MiniExcel.Core/Reflection/MiniExcelMapper.cs | 4 +++- tests/MiniExcel.Core.Tests/MiniExcelIssueTests.cs | 3 ++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/src/MiniExcel.Core/Reflection/MiniExcelMapper.cs b/src/MiniExcel.Core/Reflection/MiniExcelMapper.cs index 7e46339d..681f4d5a 100644 --- a/src/MiniExcel.Core/Reflection/MiniExcelMapper.cs +++ b/src/MiniExcel.Core/Reflection/MiniExcelMapper.cs @@ -156,7 +156,9 @@ public static partial class MiniExcelMapper if (config.DateOnlyConversionMode == DateOnlyConversionMode.RequireMidnight && dateTimeValue.TimeOfDay != TimeSpan.Zero) throw new InvalidCastException($"Could not convert cell of type DateTime to DateOnly, because DateTime was not at midnight, but at {dateTimeValue:HH:mm:ss}."); - return DateOnly.FromDateTime(dateTimeValue); + newValue = DateOnly.FromDateTime(dateTimeValue); + pInfo.Property.SetValue(v, newValue); + return newValue; } var vs = itemValue?.ToString(); diff --git a/tests/MiniExcel.Core.Tests/MiniExcelIssueTests.cs b/tests/MiniExcel.Core.Tests/MiniExcelIssueTests.cs index 6bab7c52..3c912ef9 100644 --- a/tests/MiniExcel.Core.Tests/MiniExcelIssueTests.cs +++ b/tests/MiniExcel.Core.Tests/MiniExcelIssueTests.cs @@ -3681,7 +3681,8 @@ public void TestIssue869(string fileName, DateOnlyConversionMode mode, bool thro { try { - _ = testFn(); + var result = testFn(); + Assert.Equal(new DateOnly(2025, 1, 1), result[0].Date); } catch (Exception ex) {