Skip to content

Credentials: redact password in URL #1511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 22, 2025
Merged

Credentials: redact password in URL #1511

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion minio/credentials/providers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
import ipaddress
import json
import os
import re
import socket
import sys
import time
Expand Down Expand Up @@ -80,7 +81,12 @@ def _urlopen(
"""Wrapper of urlopen() handles HTTP status code."""
res = http_client.urlopen(method, url, body=body, headers=headers)
if res.status not in [200, 204, 206]:
raise ValueError(f"{url} failed with HTTP status code {res.status}")
safe_url = re.sub(
r"LDAPPassword=([^&]+)", "LDAPPassword=*REDACTED*", url,
)
raise ValueError(
f"{safe_url} failed with HTTP status code {res.status}",
)
return res


Expand Down
Loading