code review update

Author: HJLebbink

src/s3/builders/bucket_common.rs

@@ -15,11 +15,7 @@
 
 use std::marker::PhantomData;
 
-use crate::s3::{
-    client::Client,
-    error::Error,
-    utils::{check_bucket_name, Multimap},
-};
+use crate::s3::{client::Client, utils::Multimap};
 
 #[derive(Clone, Debug, Default)]
 pub struct BucketCommon<A> {
@@ -34,12 +30,11 @@ pub struct BucketCommon<A> {
 }
 
 impl<A: Default> BucketCommon<A> {
-    pub fn new(bucket: &str) -> Result<BucketCommon<A>, Error> {
-        check_bucket_name(bucket, true)?;
-        Ok(BucketCommon {
+    pub fn new(bucket: &str) -> BucketCommon<A> {
+        BucketCommon {
             bucket: bucket.to_owned(),
             ..Default::default()
-        })
+        }
     }
 
     pub fn client(mut self, client: &Client) -> Self {

src/s3/client/get_bucket_encryption.rs

@@ -18,10 +18,12 @@
 use super::Client;
 use crate::s3::builders::GetBucketEncryption;
 use crate::s3::error::Error;
+use crate::s3::utils::check_bucket_name;
 
 impl Client {
     /// Create a GetBucketEncryption request builder.
     pub fn get_bucket_encryption(&self, bucket: &str) -> Result<GetBucketEncryption, Error> {
-        Ok(GetBucketEncryption::new(bucket)?.client(self))
+        check_bucket_name(bucket, true)?;
+        Ok(GetBucketEncryption::new(bucket).client(self))
     }
 }

src/s3/client/get_bucket_versioning.rs

@@ -18,10 +18,12 @@
 use super::Client;
 use crate::s3::builders::GetBucketVersioning;
 use crate::s3::error::Error;
+use crate::s3::utils::check_bucket_name;
 
 impl Client {
     /// Create a GetBucketVersioning request builder.
     pub fn get_bucket_versioning(&self, bucket: &str) -> Result<GetBucketVersioning, Error> {
-        Ok(GetBucketVersioning::new(bucket)?.client(self))
+        check_bucket_name(bucket, true)?;
+        Ok(GetBucketVersioning::new(bucket).client(self))
     }
 }