Skip to content

Conversation

HJLebbink
Copy link
Member

@HJLebbink HJLebbink commented Feb 3, 2025

Refactored set_bucket_versioning.

1 down, many to go...

@HJLebbink HJLebbink added the enhancement Used in release doc generation label Feb 3, 2025
@HJLebbink HJLebbink force-pushed the refactor-bucket-versioning branch 7 times, most recently from 31ed16d to 39846bb Compare February 3, 2025 19:10
@HJLebbink HJLebbink requested a review from donatello February 3, 2025 19:11
@HJLebbink HJLebbink force-pushed the refactor-bucket-versioning branch from 39846bb to 58ea810 Compare February 3, 2025 21:13
@HJLebbink HJLebbink marked this pull request as draft February 3, 2025 21:48
@HJLebbink HJLebbink force-pushed the refactor-bucket-versioning branch 4 times, most recently from c83ba00 to d036bb8 Compare February 3, 2025 22:01
@HJLebbink HJLebbink changed the title Refactor set_bucket_encryption and set_bucket_versioning Refactor set_bucket_versioning Feb 3, 2025
@HJLebbink HJLebbink force-pushed the refactor-bucket-versioning branch 3 times, most recently from 3a5f722 to d6845a2 Compare February 9, 2025 14:02
@HJLebbink HJLebbink force-pushed the refactor-bucket-versioning branch from d6845a2 to 7a4de94 Compare February 9, 2025 18:38
@HJLebbink HJLebbink marked this pull request as ready for review February 9, 2025 18:41
@HJLebbink
Copy link
Member Author

@donatello Could you please take a look

@HJLebbink HJLebbink force-pushed the refactor-bucket-versioning branch from 083500b to 16cb0d4 Compare February 10, 2025 20:38
@HJLebbink HJLebbink requested a review from donatello February 10, 2025 20:40
Copy link
Member

@donatello donatello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@donatello donatello merged commit cba673a into minio:master Feb 21, 2025
2 checks passed
@HJLebbink HJLebbink deleted the refactor-bucket-versioning branch February 21, 2025 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Used in release doc generation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants