-
Notifications
You must be signed in to change notification settings - Fork 72
refactored tests into 24 separate tests #118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
533bf80 to
08fd05c
Compare
08fd05c to
4f761d8
Compare
|
Please fix conflicts @HJLebbink |
4f761d8 to
607d63c
Compare
@donatello I rebased. Two minor issues with the code.
|
653c025 to
81ceb8c
Compare
|
I fixed that tests may not always cleanup their stuff. PTAL |
For this part, you can check a CI variable like |
|
It is also ok to hardcode play creds for running tests in the local environment. I suggest something like:
|
12e6f61 to
e9a226d
Compare
e9a226d to
14726d7
Compare
|
Hi @donatello, I've updated the creation of the TextContext from env variables. PTAL |
Note: depends on #114
Refactored one large test into separate tests. It runs 2 twice as fast as a result