Skip to content

Conversation

HJLebbink
Copy link
Member

Minor issues found while debugging an issue

@HJLebbink HJLebbink requested a review from twuebi July 10, 2025 11:26
@HJLebbink HJLebbink added documentation Improvements or additions to documentation enhancement Used in release doc generation cleanup-rewrite Used in release doc generation and removed documentation Improvements or additions to documentation enhancement Used in release doc generation labels Jul 10, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR cleans up various tests, fixes Clippy warnings, and refines minor documentation and error messages across the codebase.

  • Remove obsolete test_object_remove.rs and consolidate object-put tests with a shared helper and additional edge-case scenarios
  • Update skip logic in list-objects tests, refine bucket/object-name validation messages, and enhance delete_bucket behavior to log remaining objects
  • Apply small doc/format tweaks in builders, client methods, response error formatting, and introduce UUID-based random name generators

Reviewed Changes

Copilot reviewed 19 out of 19 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
tests/test_object_remove.rs Removed outdated test file
tests/test_object_put.rs Extracted helper, added specialized put tests
tests/test_list_objects.rs Replaced println skips with panic and added skip macros
src/s3/utils.rs Improved bucket/object name validation and error messages
src/s3/client/delete_bucket.rs Enhanced delete_bucket to purge/log non-empty buckets
common/src/utils.rs Switched random-name generators to UUID-based formats
Comments suppressed due to low confidence (1)

src/s3/utils.rs:307

  • The variable name bucket_name_n_bytes is misleading in check_object_name; it should reflect object_name, e.g., object_name_len.
    let bucket_name_n_bytes = object_name.len();

@HJLebbink HJLebbink requested a review from donatello July 10, 2025 20:08
@HJLebbink HJLebbink merged commit e244229 into minio:master Jul 11, 2025
6 checks passed
@HJLebbink HJLebbink deleted the update-tests branch July 11, 2025 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cleanup-rewrite Used in release doc generation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants