Skip to content

Conversation

HJLebbink
Copy link
Member

@HJLebbink HJLebbink commented Sep 10, 2025

This PR migrates from hand-rolled builder structs to the TypedBuilder crate, implementing a standardized builder pattern across the entire S3 client library. This change introduces the .build() method call requirement for all request builders while maintaining the existing API surface.

Adopts TypedBuilder for consistent, type-safe builder patterns across all S3 operations
Updates all client methods to return TypedBuilder-generated builder types
Adds required .build() calls to all test files for new builder API

@HJLebbink HJLebbink added the cleanup-rewrite Used in release doc generation label Sep 10, 2025
@HJLebbink HJLebbink self-assigned this Sep 10, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates from hand-rolled builder structs to the TypedBuilder crate, implementing a standardized builder pattern across the entire S3 client library. This change introduces the .build() method call requirement for all request builders while maintaining the existing API surface.

  • Adopts TypedBuilder for consistent, type-safe builder patterns across all S3 operations
  • Updates all client methods to return TypedBuilder-generated builder types
  • Adds required .build() calls to all test files for new builder API

Reviewed Changes

Copilot reviewed 204 out of 204 changed files in this pull request and generated 6 comments.

File Description
test files Updated all test method calls to include required .build() step
client files Modified all client methods to return TypedBuilder-generated builders
types.rs Updated S3Request to use TypedBuilder with proper field annotations
response files Updated documentation references from Client to MinioClient

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@HJLebbink HJLebbink force-pushed the cleanup-defaults branch 4 times, most recently from 303c43e to f7396a9 Compare September 10, 2025 15:48
@HJLebbink HJLebbink marked this pull request as ready for review September 10, 2025 15:55
@HJLebbink HJLebbink force-pushed the cleanup-defaults branch 2 times, most recently from 119def6 to 55acda0 Compare September 17, 2025 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup-rewrite Used in release doc generation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant