Skip to content

Conversation

HJLebbink
Copy link
Member

  • Update all X-Amz-* headers to use capital letters after hyphens (e.g., X-Amz-Date)
  • Update standard HTTP headers to use proper case (e.g., If-Modified-Since)
  • Update X-Minio headers to follow same capitalization pattern
  • Aligns with AWS S3 API specification and HTTP standards

  - Update all X-Amz-* headers to use capital letters after hyphens (e.g., X-Amz-Date)
  - Update standard HTTP headers to use proper case (e.g., If-Modified-Since)
  - Update X-Minio headers to follow same capitalization pattern
  - Aligns with AWS S3 API specification and HTTP standards
@HJLebbink HJLebbink self-assigned this Sep 28, 2025
@HJLebbink HJLebbink added the bug Used in release doc generation label Sep 28, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates HTTP header constants to use proper capitalization according to AWS S3 API specification and HTTP standards. The changes replace lowercase header names with proper title case format.

  • Updates all X-Amz-* headers to use capital letters after hyphens (e.g., "x-amz-date" → "X-Amz-Date")
  • Updates standard HTTP headers to use proper case (e.g., "if-modified-since" → "If-Modified-Since")
  • Updates X-Minio headers to follow the same capitalization pattern

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
src/s3/header_constants.rs Updates all HTTP header constants from lowercase to proper title case
tests/run-tests-windows.ps1 Adds environment variable fallback logic for MINIO_ROOT_USER/PASSWORD
CLAUDE.md Adds comprehensive code style guide for the MinIO Rust SDK
AGENTS.md Creates reference file pointing to CLAUDE.md

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@HJLebbink HJLebbink requested a review from twuebi September 29, 2025 12:39
@HJLebbink HJLebbink merged commit 5a90956 into minio:master Sep 29, 2025
7 checks passed
@HJLebbink HJLebbink deleted the update-header-constants branch September 29, 2025 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Used in release doc generation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants