-
-
Notifications
You must be signed in to change notification settings - Fork 125
Try add MusicBrainz tag to file #82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Maxmystere
wants to merge
43
commits into
miraclx:master
Choose a base branch
from
Maxmystere:Add-MBID-tag
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
43 commits
Select commit
Hold shift + click to select a range
dabfef3
Try add MusicBrainz tag to file
Maxmystere 4b12c70
Move logic to cli:trackQueue
Maxmystere 12aec89
Clean code
Maxmystere e4aff77
Final code cleaning and separation
Maxmystere b55eb42
Cleaner logs
Maxmystere 6ccc4b1
Sync logs
Maxmystere c95d255
Merge branch 'master' into Add-MBID-tag
miraclx fc22292
touch lookup logic, extract extra metadata
miraclx d524f78
drop AtomicParsley ignore
miraclx 524774a
Merge branch 'master' into Add-MBID-tag
miraclx cdbbac9
show error msg + code when musicbrainz lookup failed
miraclx 2fe8a68
add cli flag `-m, --musicbrainz` for enabling musicbrainz functionality
miraclx afc16e6
default storefront = us;
miraclx 2248ca1
embed release country
miraclx 4d0ba9f
apply default if not using musicbrainz
miraclx 0757056
catch and diffuse any caught error in the current execution loop
miraclx 9c1129c
prioritize storefront+digital media matches
miraclx 7825c3c
cache musicbrainz lookups for efficiency
miraclx e1a16e3
limit the scope of the args fields: inc & json only
miraclx 2d5c59b
remove static inc from template url
miraclx c370653
releaseType should be lowerCase
miraclx 52a948c
Merge branch 'miraclx:master' into Add-MBID-tag
Maxmystere e489991
Merge remote-tracking branch 'origin/master' into Add-MBID-tag
Maxmystere 320a206
Fix merge issue
Maxmystere e1ecc53
Finish merge + fixes
Maxmystere 4b79bb8
Add flac support + use taglib for tagging flac
Maxmystere a454a83
CRLF -> LF
Maxmystere b49a8e9
Disable Musicbrainz for AtomicParsley has it is unsupported
Maxmystere 8042571
Comment fix
Maxmystere cfac169
Merge branch 'master' into Add-MBID-tag
Maxmystere bec59fb
Fix format
Maxmystere c8a048b
Merge branch 'master' into Add-MBID-tag
Maxmystere 8ecc465
Secure get
Maxmystere a1b5fd3
eslint
Maxmystere 36b16e1
Up from master
Maxmystere 86fc599
Merge remote-tracking branch 'origin/master' into Add-MBID-tag
Maxmystere b84283f
LF
Maxmystere 7d6796e
Fix issue with metadata extract
Maxmystere d50b7e6
Merge remote-tracking branch 'origin/master' into Add-MBID-tag
Maxmystere 0c3f74d
Increase security
Maxmystere c3633d2
Merge remote-tracking branch 'origin/master' into Add-MBID-tag
Maxmystere 4e67396
Merge remote-tracking branch 'origin/master' into Add-MBID-tag
Maxmystere 1185531
Merge remote-tracking branch 'origin/master' into Add-MBID-tag
Maxmystere File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,3 +6,5 @@ bins/ | |
|
||
# ignore stage for testing | ||
stage/ | ||
|
||
AtomicParsley.exe |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.