UPnP IGD: Daemon fixes and improvements

[Self-Hosting-Group]

• Fix GetActiveConnections -> GetActiveConnection action and add missing allowedValueRange to MaximumActiveConnections state variable to match UPnP IGD specification
• Fix subscription timeout to match minimum of 1800s to comply with UDA specification
• Add missing and remove pre-IGDv1 error description

Fixed in 7567a2b d2d021c df0d9ca

• Consistent and compliant server header

Fixed in c552aac ee0254a

The Port Control Protocol (PCP) is the successor to NAT-PMP, has similar protocol concepts and packet formats, but adds support for IPv6 port maps and options/extensions. For more information, see:
Port Mapping Protocols Overview and Comparison 2025: About UPnP IGD & PCP/NAT-PMP
https://github.com/Self-Hosting-Group/wiki/wiki/Port-Mapping-Protocols-Overview

[Self-Hosting-Group]

@BrainSlayer Some perhaps useful PR reference links:

UPnP IGD WANCommonInterfaceConfig:1 service:
https://upnp.org/specs/gw/UPnP-gw-WANCommonInterfaceConfig-v1-Service.pdf

UDA 1.1:
https://upnp.org/specs/arch/UPnP-arch-DeviceArchitecture-v1.1.pdf

[BrainSlayer]

is this tested?

[BrainSlayer]

especially "Server: %s/%s UPnP/1.0 upnpd/0.9.0\r\n"
the first arguments for sprintf are osname and os ver. using this has server isnt correct

[BrainSlayer]

i'm merging it now partitially. but the part which changes the http header is clearly wrong %s/%s can never be a valid Server: description. this is specified as ip or hostname but never contains slashes. in that case its just a placeholder, but it still has to be in valid format. using the osname and os version as server is wrong

[BrainSlayer]

and parts of your patch is broken and does not compile.

soap.c: In function 'soap_send_error':
soap.c:282:14: error: 'SOAP_SPECIFIED_ARRAY_INDEX_INVALID' undeclared (first use in this function)
282 | case SOAP_SPECIFIED_ARRAY_INDEX_INVALID:
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
soap.c:282:14: note: each undeclared identifier is reported only once for each function it appears in
soap.c:286:14: error: 'SOAP_NO_SUCH_ENTRY_IN_ARRAY' undeclared (first use in this function)
286 | case SOAP_NO_SUCH_ENTRY_IN_ARRAY:
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
soap.c:290:14: error: 'SOAP_CONFLICT_IN_MAPPING_ENTRY' undeclared (first use in this function)
290 | case SOAP_CONFLICT_IN_MAPPING_ENTRY:
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

[BrainSlayer]

i'm currently fixing it. i also found more compile errors in other sources based on that patch.

[BrainSlayer]

the rename of arg_out_GetMaximumActiveConnections to arg_out_GetMaximumActiveConnection is also wrong. see spec

[BrainSlayer]

i commited 2 patches on top. now it does compile again

[Self-Hosting-Group]

Thanks for the compilation fix. Unfortunately, I have not yet been able to set up a build environment for dd-wrt.

especially "Server: %s/%s UPnP/1.0 upnpd/0.9.0\r\n" the first arguments for sprintf are osname and os ver. using this has server isnt correct

Could you perhaps take another look at it?

From the UDA 1.1 specification:
Server: OS/version UPnP/1.1 product/version

So a server of DD-WRT/1.2.3 UPnP/1.0 upnpd/0.9.0 should be correct, right?
Another IGD daemon uses OpenWrt/1.2.3 UPnP/1.1 MiniUPnPd/1.2.3

[BrainSlayer]

looks right. os/version etc. is correct. so if practical tests works. all is okay

[Self-Hosting-Group]

looks right. os/version etc. is correct. so if practical tests works. all is okay

As it is currently: POSIX UPnP/1.0 DD-WRT/61848
Proposed: DD-WRT/61848 UPnP/1.0 upnpd/0.9.0 (if you agree with the daemon version)
OS/version UPnP/x.x product/version

[BrainSlayer]

looks right. os/version etc. is correct. so if practical tests works. all is okay

As it is currently: POSIX UPnP/1.0 DD-WRT/61848 Proposed: DD-WRT/61848 UPnP/1.0 upnpd/0.9.0 (if you agree with the daemon version) OS/version UPnP/x.x product/version

not sure about the daemon version since we have done alot of changes over the years. also not sure if its relevant at all
see r61948 for your proposed changes.

[Self-Hosting-Group]

Thank you, but I suggested that this would comply with the UDA specs:

- "Server: %s/%s POSIX UPnP/1.0 upnpd/0.9.0\r\n"
+ "Server: %s/%s UPnP/1.0 upnpd/0.9.0\r\n"

[BrainSlayer]

makes technically no different. better now?

[Self-Hosting-Group]

makes technically no different. better now?

Perfectly, thank you very much.

[Self-Hosting-Group]

Let's keep this PR open in case I think of any further improvements.

[BrainSlayer]

its not closed. intentionally