perf(updater): offload version fetch to registry

Author: gorillamoe

internal/lib/registry_parser/root.go

@@ -19,6 +19,7 @@ type RegistryItemSource struct {
 
 type RegistryItem struct {
 	Name        string             `json:"name"`
+	Version     string             `json:"version"`
 	Description string             `json:"description"`
 	Homepage    string             `json:"homepage"`
 	Licenses    []string           `json:"licenses"`
@@ -64,3 +65,8 @@ func GetBySourceId(sourceId string) RegistryItem {
 	}
 	return RegistryItem{}
 }
+
+func GetLatestVersion(sourceId string) string {
+	item := GetBySourceId(sourceId)
+	return item.Version
+}

internal/lib/updater/github_provider.go

@@ -1,10 +1,6 @@
 package updater
 
 import (
-	"encoding/json"
-	"fmt"
-	"io"
-	"net/http"
 	"strings"
 
 	"github.com/charmbracelet/log"
@@ -19,59 +15,7 @@ func (g *GitHubProvider) getPackageId(sourceId string) string {
 	return strings.Join(parts[1:], "/")
 }
 
-// getWebUrl returns the GitHub web URL for a given source
-func (g *GitHubProvider) getWebUrl(sourceId string) string {
-	return "https://github.com/" + g.getPackageId(sourceId)
-}
-
-// getApiUrl returns the GitHub API URL for a given source
-func (g *GitHubProvider) getApiUrl(sourceId string) string {
-	return "https://api.github.com/repos/" + g.getPackageId(sourceId)
-}
-
 // Update updates a package via the GitHub provider
 func (g *GitHubProvider) Update(sourceId string) {
 	log.Info("Updating via GitHub provider", "source", sourceId)
 }
-
-func stripVersionPrefix(version string) string {
-	return strings.TrimPrefix(version, "v")
-}
-
-// GetLatestReleaseVersionNumber returns the latest release version number for a GitHub repository
-func (g *GitHubProvider) GetLatestReleaseVersionNumber(sourceId string) string {
-	url := g.getApiUrl(sourceId) + "/releases/latest"
-
-	// Create an HTTP GET request
-	resp, err := http.Get(url)
-	if err != nil {
-		fmt.Printf("Error making request: %v\n", err)
-		return ""
-	}
-	defer resp.Body.Close()
-
-	// Check if the repository exists or if there was an error
-	if resp.StatusCode != http.StatusOK {
-		fmt.Printf("GitHub API returned status code %d\n", resp.StatusCode)
-		return ""
-	}
-
-	// Read and parse the JSON response
-	body, err := io.ReadAll(resp.Body)
-	if err != nil {
-		fmt.Printf("Error reading response body: %v\n", err)
-		return ""
-	}
-
-	// Structure to hold the JSON response
-	var release struct {
-		TagName string `json:"tag_name"`
-	}
-
-	if err := json.Unmarshal(body, &release); err != nil {
-		fmt.Printf("Error parsing JSON: %v\n", err)
-		return ""
-	}
-
-	return stripVersionPrefix(release.TagName)
-}

internal/lib/updater/npm_provider.go

@@ -1,10 +1,6 @@
 package updater
 
 import (
-	"encoding/json"
-	"fmt"
-	"io"
-	"net/http"
 	"strings"
 
 	"github.com/charmbracelet/log"
@@ -19,58 +15,6 @@ func (p *NPMProvider) getPackageId(sourceId string) string {
 	return strings.Join(parts[1:], "/")
 }
 
-// getWebUrl returns the NPM web URL for a given source
-func (p *NPMProvider) getWebUrl(sourceId string) string {
-	return "https://github.com/" + p.getPackageId(sourceId)
-}
-
-// getApiUrl returns the NPM API URL for a given source
-func (p *NPMProvider) getApiUrl(sourceId string) string {
-	return "https://registry.npmjs.org/" + p.getPackageId(sourceId)
-}
-
-func (p *NPMProvider) stripVersionPrefix(version string) string {
-	return strings.TrimPrefix(version, "v")
-}
-
 func (p *NPMProvider) Update(source string) {
 	log.Info("Updating via NPM provider", "source", source)
 }
-
-// GetLatestReleaseVersionNumber returns the latest release version number for a NPM package
-func (p *NPMProvider) GetLatestReleaseVersionNumber(sourceId string) string {
-	url := p.getApiUrl(sourceId) + "/latest"
-
-	// Create an HTTP GET request
-	resp, err := http.Get(url)
-	if err != nil {
-		fmt.Printf("Error making request: %v\n", err)
-		return ""
-	}
-	defer resp.Body.Close()
-
-	// Check if the repository exists or if there was an error
-	if resp.StatusCode != http.StatusOK {
-		fmt.Printf("API returned status code %d\n", resp.StatusCode)
-		return ""
-	}
-
-	// Read and parse the JSON response
-	body, err := io.ReadAll(resp.Body)
-	if err != nil {
-		fmt.Printf("Error reading response body: %v\n", err)
-		return ""
-	}
-
-	// Structure to hold the JSON response
-	var release struct {
-		Version string `json:"version"`
-	}
-
-	if err := json.Unmarshal(body, &release); err != nil {
-		fmt.Printf("Error parsing JSON: %v\n", err)
-		return ""
-	}
-
-	return p.stripVersionPrefix(release.Version)
-}

internal/lib/updater/root.go

@@ -3,6 +3,7 @@ package updater
 import (
 	"strings"
 
+	"github.com/mistweaverco/zana-client/internal/lib/registry_parser"
 	"github.com/mistweaverco/zana-client/internal/lib/semver"
 )
 
@@ -38,44 +39,17 @@ func detectProvider(sourceId string) Provider {
 	return provider
 }
 
-func GetLatestReleaseVersionNumber(sourceId string) string {
-	provider := detectProvider(sourceId)
-	switch provider {
-	case ProviderGitHub:
-		return gitHubProvider.GetLatestReleaseVersionNumber(sourceId)
-	case ProviderNPM:
-		return npmProvider.GetLatestReleaseVersionNumber(sourceId)
-	case ProviderUnsupported:
-		// Unsupported provider
-		return ""
-	default:
-		return ""
-	}
-}
-
 // CheckIfUpdateIsAvailable checks if an update is available for a given package
 // and returns a boolean indicating if an update is available and the latest version number
 func CheckIfUpdateIsAvailable(version string, sourceId string) (bool, string) {
-	provider := detectProvider(sourceId)
-	switch provider {
-	case ProviderGitHub:
-		latestVersion := gitHubProvider.GetLatestReleaseVersionNumber(sourceId)
-		if semver.IsGreater(version, latestVersion) {
-			return true, latestVersion
-		}
-		return false, latestVersion
-	case ProviderNPM:
-		latestVersion := npmProvider.GetLatestReleaseVersionNumber(sourceId)
-		if semver.IsGreater(version, latestVersion) {
-			return true, latestVersion
-		}
-		return false, latestVersion
-	case ProviderUnsupported:
-		// Unsupported provider
-		return false, ""
-	default:
+	latestVersion := registry_parser.GetLatestVersion(sourceId)
+	if latestVersion == "" {
 		return false, ""
 	}
+	if semver.IsGreater(version, latestVersion) {
+		return true, latestVersion
+	}
+	return false, ""
 }
 
 func Update(sourceId string) {

internal/lib/updater/source_parser.go

@@ -4,16 +4,6 @@ import "strings"
 
 type SourceParser struct{}
 
-func (sp *SourceParser) getLatestReleaseVersionNumber(source string) string {
-	provider, packageId := sp.ParseSource(source)
-	switch provider {
-	case "github":
-		return gitHubProvider.GetLatestReleaseVersionNumber(packageId)
-	default:
-		return ""
-	}
-}
-
 func (sp *SourceParser) ParseSource(source string) (string, string) {
 	source = strings.TrimPrefix(source, "pkg:")
 	parts := strings.Split(source, "/")