Conditionally ask for READ_MEDIA permissions if declared #3556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I77f1487c242ffd7a67df2605e6590291a9fb6b0e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: I77f1487c242ffd7a67df2605e6590291a9fb6b0e
General items:
ant testspasses on my machineIf your code changes how something works on the device (i.e., it affects the companion):
ucrucras the baseWhat does this PR accomplish?
This PR fixes an issue where file operations may still ask for READ_MEDIA permissions even if the app doesn't declare them (due to removal of those perms in a previous commit). This change conditionally adds the READ_MEDIA permissions if the app actually has them declared, otherwise it does nothing. In apps without these permissions, a read may fail if the permission is needed, in which case the user will need to add the corresponding permission block to their app (but this would have already been true of ucr since the app didn't have the requisite permission in any case), and only affects apps on Tiramisu or higher.