-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Added @UsesFeatures annotation #3570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Added @UsesFeatures annotation #3570
Conversation
Can one of the admins verify this patch? |
1 similar comment
Can one of the admins verify this patch? |
@AppInventorWorkerBee ok to test |
...onents/src/com/google/appinventor/components/annotations/androidmanifest/FeatureElement.java
Show resolved
Hide resolved
appinventor/components/src/com/google/appinventor/components/annotations/UsesFeatures.java
Outdated
Show resolved
Hide resolved
...onents/src/com/google/appinventor/components/annotations/androidmanifest/FeatureElement.java
Outdated
Show resolved
Hide resolved
appinventor/components/src/com/google/appinventor/components/annotations/UsesFeatures.java
Outdated
Show resolved
Hide resolved
...nventor/buildserver/src/com/google/appinventor/buildserver/tasks/android/CreateManifest.java
Outdated
Show resolved
Hide resolved
@AppInventorWorkerBee ok to test |
- If a duplicate is found, it only takes the required one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor change, otherwise LGTM.
...onents/src/com/google/appinventor/components/annotations/androidmanifest/FeatureElement.java
Outdated
Show resolved
Hide resolved
I had another thought, and this would be a breaking change so we may want it as a separate PR... but we may want to add the |
Default value is false.
General items:
ant tests
passes on my machineIf your code changes how something works on the device (i.e., it affects the companion):
ucr
ucr
as the baseFurther, if you've changed the blocks language or another user-facing designer/blocks API (added a SimpleProperty, etc.):
For all other changes:
master
master
as the baseWhat does this PR accomplish?
Added the ability to declare <uses-feature> element in AndroidManifest.xml.
Example usage # .
Resolves # .