Update to Blockly 11 #3588
Update to Blockly 11 #3588
Conversation
|
I just found a bug that I'll work on next. While delete count is correct (includes children too) when selecting multiple blocks only the block (and its children, if any) you right click on is deleted. |
|
Is this true in master as well? In either case the issue will be somewhere in the multi select plugin.Sent from my iPhoneOn Sep 5, 2025, at 18:33, Michael Gallagher ***@***.***> wrote:mjgallag left a comment (mit-cml/appinventor-sources#3588)
I just found a bug that I'll work on next. While delete count is correct (includes children too) when selecting multiple blocks only the block (and its children, if any) you right click on is deleted.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
|
@ewpatton it works in master so I either messed up the merge mit-cml/workspace-multiselect@main...mjgallag:workspace-multiselect:update-to-blockly-11 or its a Blockly 11 issue with the plugin. |
|
@ewpatton its reproducible on main branch of multiselect plugin but works if I try commit before it was upgraded to Blockly 11. |
|
@ewpatton ha ... now i'm not so sure about any of my statements regarding this bug ... tbd |
|
Ah ha, it's a subtle bug that was introduced when the multiselect plugin was upgraded to Blockly 11. If you keep the shift key pressed when you right click the yellow borders of multiple select are lost and even though context menu has correct multiple counts it only acts on block you right clicked. If you let go of shift key after making your selections and before right clicking it works as expected. Will look into this but will get test instance up first so people can play with it in parallel with my bug fixing. |
|
https://arched-branch-471517-f9.uc.r.appspot.com/ here is an appspot instance for playing around with this |
mjgallag
force-pushed
the
update-to-blockly-11
branch
from
8eb92fc to
785162b
Compare
mjgallag
force-pushed
the
update-to-blockly-11
branch
2 times, most recently
from
aba67f3 to
ca30347
Compare
|
OK that bug is fixed and https://arched-branch-471517-f9.uc.r.appspot.com/ has been updated. Also there is no more fork for multiselect. I have marked this ready for review. I expect more bugs will probably be found but I think it's ready for more eyes. |
|
I just noticed with https://appinventor.mit.edu/explore/tips/typeblocking the blocks are landing on top of each other in this branch instead of staggered like on master. @josmas I think I am going to try to integrate your plugin https://github.com/josmas/blockly-plugins/tree/feat/typeblocking as part of this Blockly 11 branch. |
mjgallag
force-pushed
the
update-to-blockly-11
branch
from
ca30347 to
9e5b36b
Compare
setWarningText checks for warning icon https://github.com/google/blockly/blob/blockly-v11.2.2/core/block_svg.ts#L972 google/blockly@75007a0#diff-bb0de0069443e7577f62ffa96e6b51c5fafd06703f50c3eed6eb616ac87467bfL118-L124 https://developers.google.com/blockly/reference/js/blockly.blocksvg_class.setwarningtext_1_method.md
mjgallag
force-pushed
the
update-to-blockly-11
branch
from
9e5b36b to
4903e4d
Compare
|
Nevermind I just fixed the bugs as moving to @josmas typeblocking plugin should be a separate pull. This bug lead me to fix the same bug in a few different places and also lead me to notice paste from backapck was broken, that fix was pretty interesting. In any case https://arched-branch-471517-f9.uc.r.appspot.com/ has been updated. I am off next week and a half. If anyone gets around to testing this please leave bugs in the comments for my return. But as of now I have fixed all I have discovered. |
google/blockly@75007a0#diff-5175ae7b6cd103f9910b04fab3e7c4b2007b60078a396af66e63a6e8c63e6aceL1326 https://github.com/google/blockly/blob/blockly-v10.4.3/core/workspace_svg.ts#L1373 https://github.com/google/blockly/blob/blockly-v11.2.2/core/clipboard.ts#L39 https://github.com/google/blockly/blob/blockly-v11.2.2/core/clipboard/block_paster.ts#L74
mjgallag
force-pushed
the
update-to-blockly-11
branch
from
4903e4d to
679af08
Compare
3 participants
General items:
ant testspasses on my machineIf your code changes how something works on the device (i.e., it affects the companion):
ucrucras the baseFurther, if you've changed the blocks language or another user-facing designer/blocks API (added a SimpleProperty, etc.):
For all other changes:
mastermasteras the baseWhat does this PR accomplish?
Updates Blockly to v11.
Resolves #3434, Resolves #3529, Resolves #3530, Resolves #3531, Resolves #3532