Skip to content

Fix deflection #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix deflection #33

wants to merge 2 commits into from

Conversation

turiyadev
Copy link

This PR fixes a couple of things related to speed-of-light corrections:

  • Fix the deflection calculation for stars (it was passing the wrong parameters)
  • Rename deflectioon -> deflection throughout
  • Run grunt build: NB. the most recent version of the bundle was missing the light-corrected apparent geocentricDistance calculation from planet.js
  • Bump version (potential breaking change, body.position.deflectioon -> body.position.deflection)
  • Restore repository URL in package.json

Fixes #18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

possible typo's in code.
1 participant
@turiyadev