Skip to content

Hide "Show All Reviews" button when all reviews are already shown #781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gabrbrand opened this issue Feb 22, 2025 · 4 comments · Fixed by #782
Closed

Hide "Show All Reviews" button when all reviews are already shown #781

gabrbrand opened this issue Feb 22, 2025 · 4 comments · Fixed by #782
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@gabrbrand
Copy link
Contributor

When an extension has less than six reviews there is no need to show them in the seperate comments dialog. Therefore it would make sense to hide the button to display the dialog.

Image
Image

(Version 0.6.1 on Fedora 41)

Also the naming is inconsistent. In some areas it's "Reviews" but in others "Comments".

(I don't know if it makes sense in the reviews section but maybe a Button Row or "Pill" style class could be used.)
@oscfdezdz oscfdezdz added enhancement New feature or request good first issue Good for newcomers labels Feb 22, 2025
@oscfdezdz
Copy link
Collaborator

Also the naming is inconsistent. In some areas it's "Reviews" but in others "Comments".

We could use "Reviews and Comments" from #67 (comment) even if we differ from Extensions web, "User Reviews".

(I don't know if it makes sense in the reviews section but maybe a Button Row or "Pill" style class could be used.)

Checking HIG, it seems like it this case it should be a pill styled button since reviews section is not a boxed list but a grid with card style childs, although in small window sizes like the one you've shared, it could look better that a pill button. See also https://developer.gnome.org/hig/patterns/controls/buttons.html#button-styles. I'll test and get back to you with screenshots.

@oscfdezdz
Copy link
Collaborator

The pill style button seems the best choice for both cases, although the button row looks better in small sizes. What do you think?

Pill button Button row
Image Image
Image Image

@oscfdezdz
Copy link
Collaborator

oscfdezdz commented Feb 22, 2025 •
edited
Loading

Not sure about using "Reviews and Comments" now that I've checked all occurrences, we have:

  • User Reviews -> Reviews and Comments
  • Show All Reviews -> Show All
  • Comments -> Reviews and Comments
  • Loading Comments -> Loading ("Reviews and Comments" is in the dialog title)
  • Comments are disabled for this extension -> Reviews and comments are disabled for this extension
  • No comments yet -> There are no reviews or comments (Extensions web uses "There are no comments. Be the first!", so we could use a similar string)

@gabrbrand
Copy link
Contributor Author

The pill style button seems the best choice for both cases, although the button row looks better in small sizes. What do you think?

I agree. The pill shaped button is probably the best solution for both desktop/mobile, if you want to change it.
The button row looks a bit to wide with empty space on the right on desktop.

The updated strings look good to me.

oscfdezdz added a commit that referenced this issue Feb 22, 2025
@oscfdezdz
detail-view: Hide "Show All Reviews" button when unneeded
2fefbab 
We retrieve comments in the details view and the comment dialog using
different queries. Therefore, we must display the button in extensions
that have exactly five reviews/comments, as we do not know the total
count until we query all comments when the dialog is opened.

Also rewords strings containing comment or review to use both terms as
they are both possible and adds pill style to the button.

Close #781
@oscfdezdz oscfdezdz mentioned this issue Feb 22, 2025
Merged
oscfdezdz added a commit that referenced this issue Feb 22, 2025
@oscfdezdz
detail-view: Hide "Show All Reviews" button when unneeded
9563728 
We retrieve reviews/comments in the details view and the comment dialog
using different queries. Because we do not know the total count until
querying all of them in the dialog, we have to display the button for
extensions with exactly five or more reviews/comments, rather than
strictly more than five.

Also rewords strings containing comment or review to use both terms as
they are both possible and adds pill style to the button.

Close #781
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

detail-view: Hide "Show All Reviews" button when unneeded mjakeman/extension-manager
2 participants
@oscfdezdz @gabrbrand