Skip to content

Commit 3d99b81

Browse files
db-willmjonss
authored andcommitted
Redact query arguments in dm log (pingcap#11783)
close pingcap#11489
1 parent 0603517 commit 3d99b81

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

dm/syncer/dbconn/db.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -246,7 +246,7 @@ func (conn *DBConn) retryableFn(tctx *tcontext.Context, queries, args any) func(
246246
if err != nil {
247247
tctx.L().Error("reset connection failed", zap.Int("retry", retryTime),
248248
zap.String("queries", utils.TruncateInterface(queries, -1)),
249-
zap.String("arguments", utils.TruncateInterface(args, -1)),
249+
log.ZapRedactString("arguments", utils.TruncateInterface(args, -1)),
250250
log.ShortError(err))
251251
return false
252252
}
@@ -257,7 +257,7 @@ func (conn *DBConn) retryableFn(tctx *tcontext.Context, queries, args any) func(
257257
if dbutil.IsRetryableError(err) {
258258
tctx.L().Warn("execute statements", zap.Int("retry", retryTime),
259259
zap.String("queries", utils.TruncateInterface(queries, -1)),
260-
zap.String("arguments", utils.TruncateInterface(args, -1)),
260+
log.ZapRedactString("arguments", utils.TruncateInterface(args, -1)),
261261
log.ShortError(err))
262262
return true
263263
}

0 commit comments

Comments
 (0)