Fix CJK MTEXT rendering with tiny wrap width#264
Open
mi-chow wants to merge 1 commit into
Open
Conversation
Owner
|
@mi-chow Thanks for your PR. Can you share me dxf file that you used so that I can have a try. Moreover, it looks like that it is better to move this change to module mtext-renderer instead of cad-viewer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes MTEXT rendering when a DXF contains a positive wrap width that is smaller than the text height.
In this case, the MTEXT renderer treats the tiny value as the word-wrap width, which forces CJK text to wrap one character per line. This patch detects clearly impossible MTEXT widths and estimates a usable width from the longest explicit MTEXT line while preserving explicit line breaks such as
\P.Test
corepack pnpm test -- packages/three-renderer/__tests__/AcTrMText.spec.ts