From 5283fc173cae4cbef243cf27a33916849f3a819e Mon Sep 17 00:00:00 2001
From: be-marc <marcbecker@posteo.de>
Date: Fri, 12 Sep 2025 12:02:29 +0200
Subject: [PATCH] feat: add logical, factor and ordered to supported feature
 types of boruta

---
 DESCRIPTION                         | 2 +-
 R/FilterBoruta.R                    | 2 +-
 tests/testthat/test_filter_boruta.R | 7 +++++++
 3 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/DESCRIPTION b/DESCRIPTION
index 96ba6474..efd8f724 100644
--- a/DESCRIPTION
+++ b/DESCRIPTION
@@ -54,7 +54,7 @@ Config/testthat/edition: 3
 Encoding: UTF-8
 NeedsCompilation: no
 Roxygen: list(markdown = TRUE, r6 = TRUE)
-RoxygenNote: 7.3.2
+RoxygenNote: 7.3.3
 Collate:
     'Filter.R'
     'mlr_filters.R'
diff --git a/R/FilterBoruta.R b/R/FilterBoruta.R
index 9c088dfb..45e333e1 100644
--- a/R/FilterBoruta.R
+++ b/R/FilterBoruta.R
@@ -60,7 +60,7 @@ FilterBoruta = R6Class("FilterBoruta",
         task_types = c("regr", "classif"),
         param_set = param_set,
         packages = "Boruta",
-        feature_types = c("integer", "numeric"),
+        feature_types = c("logical", "integer", "numeric", "factor", "ordered"),
         label = "Burota",
         man = "mlr3filters::mlr_filters_boruta"
       )
diff --git a/tests/testthat/test_filter_boruta.R b/tests/testthat/test_filter_boruta.R
index f63afe62..20bb89c2 100644
--- a/tests/testthat/test_filter_boruta.R
+++ b/tests/testthat/test_filter_boruta.R
@@ -4,3 +4,10 @@ test_that("filter boruta works", {
   f$calculate(task)
   expect_filter(f, task = task)
 })
+
+test_that("filter boruta works with factors", {
+  task = tsk("breast_cancer")
+  f = flt("boruta")
+  f$calculate(task)
+  expect_filter(f, task = task)
+})