fix: coercion of null default values #360
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnahkies
reviewed
Aug 13, 2025
| '"const x = z.coerce.number().nullable().default(null)"', | ||
| ) | ||
|
|
||
| await expect(execute(undefined)).resolves.toBeNull |
There was a problem hiding this comment.
Suggested change
| await expect(execute(undefined)).resolves.toBeNull | |
| await expect(execute(undefined)).resolves.toBeNull() |
(same for all the toBeNull assertions)
There was a problem hiding this comment.
(surprised that linting didn't catch this tbh - will look into that separately)
mnahkies
added a commit
that referenced
this pull request
Aug 13, 2025
apply fix/tests from #360 to the joi schema builder
mnahkies
added a commit
that referenced
this pull request
Aug 13, 2025
apply fix/tests from #360 to the joi schema builder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A default of
nullwas being coerced into"null".when the model is nullable, keep it as a
null