Skip to content

Conversation

TG199
Copy link

@TG199 TG199 commented Sep 21, 2025

PR Checklist

Overview

Signed-off-by: Kelechi Ebiri <ebiritg@gmail.com>
@TG199 TG199 changed the title Repo: Add typescript-async-loaders example feat: Add typescript-async-loaders example Sep 22, 2025
@TG199 TG199 changed the title feat: Add typescript-async-loaders example Feat: Add typescript-async-loaders example Sep 22, 2025
@mark-wiemer
Copy link
Member

Thanks @TG199 ! I reworked this example to simplify it and added a readme, please let me know if I accidentally removed anything critical :)

@JoshuaKGoldberg JoshuaKGoldberg changed the title Feat: Add typescript-async-loaders example feat: Add typescript-async-loaders example Sep 30, 2025
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with the one note on the last bit of phrasing in the README.md. 🚀

@JoshuaKGoldberg JoshuaKGoldberg changed the title feat: Add typescript-async-loaders example feat: add typescript-async-loaders example Sep 30, 2025
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, except for the failing test builds in CI.

Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>
@mark-wiemer
Copy link
Member

Yeah lerna doesn't like NODE_OPTIONS, @TG199 if you could look into a fix for that we'd appreciate it, otherwise I'll come back to this one in a bit

@TG199
Copy link
Author

TG199 commented Oct 2, 2025

Alright, I'll look into it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants