-
-
Notifications
You must be signed in to change notification settings - Fork 155
feat: add typescript-async-loaders example #123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Kelechi Ebiri <ebiritg@gmail.com>
Thanks @TG199 ! I reworked this example to simplify it and added a readme, please let me know if I accidentally removed anything critical :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, with the one note on the last bit of phrasing in the README.md. 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, except for the failing test builds in CI.
Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>
Yeah lerna doesn't like NODE_OPTIONS, @TG199 if you could look into a fix for that we'd appreciate it, otherwise I'll come back to this one in a bit |
Alright, I'll look into it |
PR Checklist
status: accepting prs
Overview