Feat: Core SDK improvements necessary for token gated mini apps #101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: cfcbbf4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 17 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
6 tasks
davidfurlong
changed the title
stephancill
suggested changes
Dec 2, 2023
examples/api/next.config.js
Outdated
Comment on lines
3
to
7
| transpilePackages: [ | ||
| "@mod-protocol/react", | ||
| // Fixes https://discord.com/channels/896185694857343026/1174716239508156496 | ||
| "@lit-protocol/bls-sdk", | ||
| ], |
There was a problem hiding this comment.
Should this change + lit-related packages in package.json not be in the token gated casts PR?
Comment on lines
+890
to
+895
| // domain: this.replaceInlineContext(action.data.domain), | ||
| // address: this.replaceInlineContext(action.data.address), | ||
| statement: this.replaceInlineContext(action.data.statement), | ||
| // uri: this.replaceInlineContext(action.data.uri), | ||
| version: this.replaceInlineContext(action.data.version), | ||
| chainId: this.replaceInlineContext(action.data.chainId), |
There was a problem hiding this comment.
Should domain, address, uri not be exposed?
There was a problem hiding this comment.
this is done by the implementing app in the action handler
stephancill
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is #92 without the Lit protocol mini apps.
comboboxelementselectelementtextareaelementModel Definitionspublished by Mini-apps that can be expressed inschema.orgschemasloadingLabelprop to buttonsethPersonalSignmodActionjson-ldjson-ldindexing to the metadata indexer (arweave and local)/api/cast-embeds-metadata/by-urlOpen todos:
json-ldto the metascraperWould particularly like a review on this proposed way of doing Model definitions. Is there a strong case that these should be separate from Mini-apps entirely instead?