fix(image-render): match image embeds based on file extension in url #29
Conversation
🦋 Changeset detectedLatest commit: f212721 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
stephancill
force-pushed
the
fix/image-render-matching
branch
from
747b942 to
d5f6163
Compare
| { equals: "{{embed.metadata.image.url}}" }, | ||
| { endsWith: ".png" }, | ||
| { endsWith: ".jpg" }, | ||
| { endsWith: ".jpeg" }, |
There was a problem hiding this comment.
What about .webp?
How are we handling when theres no file extension but the content type has an image?
There was a problem hiding this comment.
Will add .webp
If there is no file extension and the open-graph API recognizes that the endpoint has an image it will be matched by embed.metadata.image.url. #16 also adds a mimeType attribute to the UrlMetadata type so we can match that too when it's merged.
There was a problem hiding this comment.
ok - how do you want to go about the two PRs interdependence? happy with whatever
There was a problem hiding this comment.
Should be fine to merge this now and open a new PR with the mimeType change when it's available. This should handle the vast majority of cases fine in the meantime
stephancill
force-pushed
the
fix/image-render-matching
branch
from
d5f6163 to
f212721
Compare
Updated
image-renderminiapp content entry points to be matched when the embed URL ends with common image extensions i.e..png,.jpg,.jpeg,.gif,.svg, and.webp