Skip to content

Conversation

@dsp-ant
Copy link
Member

@dsp-ant dsp-ant commented Oct 6, 2025

Summary

  • Adds .pre-commit-config.yaml with standard code quality checks
  • Includes trailing whitespace, EOF, YAML validation, and merge conflict detection
  • Adds TypeScript type checking via npm run build
  • Expensive checks like Pulumi preview are excluded to run on CI instead

Test plan

  • Install pre-commit: pip install pre-commit or brew install pre-commit
  • Run pre-commit install to set up the git hooks
  • Run pre-commit run --all-files to test all hooks
  • Verify TypeScript compilation works

🤖 Generated with Claude Code

dsp-ant and others added 2 commits October 6, 2025 13:40
Includes standard checks (trailing whitespace, EOF, YAML, merge conflicts) and TypeScript type checking. Expensive checks like Pulumi preview are intentionally excluded for CI instead.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@dsp-ant dsp-ant requested a review from domdomegg October 6, 2025 11:45
@domdomegg domdomegg changed the title Add pre-commit hooks for code quality Add a-akimov to quickstart-resources; Add pre-commit hooks for code quality Oct 6, 2025
domdomegg
domdomegg previously approved these changes Oct 6, 2025
@dsp-ant dsp-ant dismissed domdomegg’s stale review October 6, 2025 20:03

The merge-base changed after approval.

@domdomegg domdomegg merged commit 6e41d74 into main Oct 6, 2025
4 checks passed
@domdomegg domdomegg deleted the add-pre-commit-hooks branch October 6, 2025 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants