Skip to content

Conversation

BraveY
Copy link
Contributor

@BraveY BraveY commented Mar 3, 2025

  • Replaced filepath.Glob with doublestar.Glob to support advanced glob patterns (e.g., **/*.py for recursive matching).

@BraveY BraveY force-pushed the feat-global-pattern branch from 56e79e1 to 927a10c Compare March 3, 2025 12:36
gaius-qi
gaius-qi previously approved these changes Mar 3, 2025
Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

BraveY added 2 commits March 4, 2025 10:08
…nhanced pattern matching

- Replaced `filepath.Glob` with `doublestar.Glob` to support advanced glob patterns (e.g., `**/*.py` for recursive matching).

Signed-off-by: Yang Kaiyong <yangkaiyong.yky@antgroup.com>
…delfile

Added a detailed explanation of the unix-like glob path pattern.

Signed-off-by: Yang Kaiyong <yangkaiyong.yky@antgroup.com>
@BraveY BraveY force-pushed the feat-global-pattern branch from decb6f8 to ea5b98e Compare March 4, 2025 02:09
@chlins
Copy link
Member

chlins commented Mar 4, 2025

Currently, the glob path in the standard library is based on the standard implementation, and most language implementations are relatively uniform. While doublestar introduces convenience, it also introduces additional interpretation costs for users. So let's hold off for now and merge when there are similar requirements.

@chlins chlins added the hold label Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants