Skip to content

Conversation

imeoer
Copy link
Collaborator

@imeoer imeoer commented Sep 3, 2025

This pull request introduces a comprehensive Helm chart for deploying the model-csi-driver on Kubernetes, along with supporting infrastructure for CI/CD and testing. The main changes include the addition of Helm chart files, GitHub Actions workflows for linting, unit, and end-to-end testing, and supporting configuration and test files.

Helm Chart Introduction and Configuration:

  • Added a new Helm chart for model-csi-driver, including chart metadata (Chart.yaml), default values (values.yaml), helper templates (_helpers.tpl), and .helmignore for packaging. [1] [2] [3] [4]
  • Introduced templates for Kubernetes resources: DaemonSet, ConfigMap for configuration, ConfigMap for Docker registry authentication, and CRDs for ServiceAccount, CSIDriver, and StorageClass. [1] [2] [3] [4]

CI/CD Workflow Enhancements:

  • Added GitHub Actions workflows for linting, unit testing, and end-to-end (E2E) testing, all triggered on push, pull request, and scheduled nightly runs. These workflows include caching, building, and deploying the driver in a Kind cluster for E2E tests. [1] [2] [3]

Supporting Files for Build and Test:

  • Added a minimal Dockerfile for building the model-csi-driver container image.
  • Added a test pod manifest (pod.test.yaml) to verify the presence of model files via the CSI driver in E2E tests.

@imeoer imeoer force-pushed the ci-e2e branch 25 times, most recently from becd52b to 0c4b138 Compare September 9, 2025 04:02
@imeoer imeoer changed the title ci: prepare for e2e test ci: add e2e test Sep 9, 2025
@imeoer imeoer force-pushed the ci-e2e branch 3 times, most recently from a767271 to 1c01c3c Compare September 9, 2025 07:04
@imeoer imeoer changed the title ci: add e2e test ci: add ut and e2e test Sep 9, 2025
@imeoer imeoer force-pushed the ci-e2e branch 12 times, most recently from 73dda79 to c2ae2a1 Compare September 9, 2025 09:08
@imeoer imeoer marked this pull request as ready for review September 9, 2025 09:12
@imeoer imeoer force-pushed the ci-e2e branch 7 times, most recently from 9b89153 to 9b9103a Compare September 9, 2025 10:35
- add model-csi-driver helm chart
- install and test chart in kind cluster

Signed-off-by: imeoer <yansong.ys@antgroup.com>
Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chlins chlins merged commit 001decf into modelpack:main Sep 10, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants