-
Notifications
You must be signed in to change notification settings - Fork 3
ci: add ut and e2e test #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
becd52b
to
0c4b138
Compare
a767271
to
1c01c3c
Compare
73dda79
to
c2ae2a1
Compare
gaius-qi
requested changes
Sep 9, 2025
gaius-qi
requested changes
Sep 9, 2025
gaius-qi
requested changes
Sep 9, 2025
9b89153
to
9b9103a
Compare
gaius-qi
requested changes
Sep 10, 2025
- add model-csi-driver helm chart - install and test chart in kind cluster Signed-off-by: imeoer <yansong.ys@antgroup.com>
gaius-qi
approved these changes
Sep 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
chlins
approved these changes
Sep 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a comprehensive Helm chart for deploying the
model-csi-driver
on Kubernetes, along with supporting infrastructure for CI/CD and testing. The main changes include the addition of Helm chart files, GitHub Actions workflows for linting, unit, and end-to-end testing, and supporting configuration and test files.Helm Chart Introduction and Configuration:
model-csi-driver
, including chart metadata (Chart.yaml
), default values (values.yaml
), helper templates (_helpers.tpl
), and .helmignore for packaging. [1] [2] [3] [4]DaemonSet
,ConfigMap
for configuration,ConfigMap
for Docker registry authentication, and CRDs forServiceAccount
,CSIDriver
, andStorageClass
. [1] [2] [3] [4]CI/CD Workflow Enhancements:
Supporting Files for Build and Test:
model-csi-driver
container image.pod.test.yaml
) to verify the presence of model files via the CSI driver in E2E tests.