Skip to content

[FEATURE] Support for Tensor-Parallel #285

@vadimkantorov

Description

@vadimkantorov

If I understand correctly, for more precise set-up of TP within FSDP2 framework, parallelize_module(...) must be called explicitly with a tp_plan (https://docs.pytorch.org/tutorials/intermediate/TP_tutorial.html#combine-tensor-parallel-with-fully-sharded-data-parallel-together), example at https://github.com/pytorch/torchtune/blob/main/recipes/full_finetune_distributed.py

But as I found, Verl/Trinity do not prepare any explicit TP-plan and do not invoke parallelize_module(...). Am I correct that TP is not currently supported under the FSDP/2 trainer?

Thanks!

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions