Update subproject commit reference to indicate a dirty state#199
Update subproject commit reference to indicate a dirty state#199xxomega77xx wants to merge 2 commits intomodery:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the PowerDocu project to target the Windows-specific .NET framework and performs code cleanup. The changes modernize the codebase by removing unused debug variables and unnecessary async modifiers.
Changes:
- Updated target framework from
net8.0tonet8.0-windowsacross multiple project files - Removed unused debug variables (
string s = "") from multiple source files - Removed unnecessary
asyncmodifiers from event handlers that don't perform asynchronous operations - Enabled nullable reference types in CommandLineOptions.cs
- Updated subproject commit reference for PowerDocu.Common
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| modules/PowerDocu.Common | Updated subproject commit reference |
| PowerDocu.SolutionDocumenter/PowerDocu.SolutionDocumenter.csproj | Changed target framework to net8.0-windows |
| PowerDocu.SolutionDocumenter/DataverseGraphBuilder.cs | Removed unused debug variable |
| PowerDocu.GUI/PowerDocuForm.cs | Removed async modifiers from synchronous event handlers |
| PowerDocu.GUI/PowerDocu.GUI.csproj | Changed SDK from WindowsDesktop to standard .NET SDK |
| PowerDocu.GUI/CommandLineOptions.cs | Enabled nullable reference types |
| PowerDocu.FlowDocumenter/PowerDocu.FlowDocumenter.csproj | Changed target framework to net8.0-windows |
| PowerDocu.FlowDocumenter/FlowWordDocBuilder.cs | Removed unused debug variable |
| PowerDocu.FlowDocumenter/FlowMarkdownBuilder.cs | Removed unused debug variable |
| PowerDocu.AppDocumenter/PowerDocu.AppDocumenter.csproj | Changed target framework to net8.0-windows |
| PowerDocu.AppDocumenter/AppWordDocBuilder.cs | Removed unused exception variable |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -1,4 +1,4 @@ | |||
| <Project Sdk="Microsoft.NET.Sdk.WindowsDesktop"> | |||
| <Project Sdk="Microsoft.NET.Sdk"> | |||
There was a problem hiding this comment.
Changing from Microsoft.NET.Sdk.WindowsDesktop to Microsoft.NET.Sdk may cause build issues or loss of Windows-specific features. The WindowsDesktop SDK provides additional functionality for WPF and WinForms applications. Verify that all Windows-specific features still work correctly with the standard SDK, or consider keeping the WindowsDesktop SDK while using the net8.0-windows target framework.
| <Project Sdk="Microsoft.NET.Sdk"> | |
| <Project Sdk="Microsoft.NET.Sdk.WindowsDesktop"> |
No description provided.