Skip to content

Update subproject commit reference to indicate a dirty state#199

Open
xxomega77xx wants to merge 2 commits intomodery:mainfrom
xxomega77xx:Fixes
Open

Update subproject commit reference to indicate a dirty state#199
xxomega77xx wants to merge 2 commits intomodery:mainfrom
xxomega77xx:Fixes

Conversation

@xxomega77xx
Copy link

No description provided.

Copilot AI review requested due to automatic review settings February 19, 2026 04:17
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the PowerDocu project to target the Windows-specific .NET framework and performs code cleanup. The changes modernize the codebase by removing unused debug variables and unnecessary async modifiers.

Changes:

  • Updated target framework from net8.0 to net8.0-windows across multiple project files
  • Removed unused debug variables (string s = "") from multiple source files
  • Removed unnecessary async modifiers from event handlers that don't perform asynchronous operations
  • Enabled nullable reference types in CommandLineOptions.cs
  • Updated subproject commit reference for PowerDocu.Common

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
modules/PowerDocu.Common Updated subproject commit reference
PowerDocu.SolutionDocumenter/PowerDocu.SolutionDocumenter.csproj Changed target framework to net8.0-windows
PowerDocu.SolutionDocumenter/DataverseGraphBuilder.cs Removed unused debug variable
PowerDocu.GUI/PowerDocuForm.cs Removed async modifiers from synchronous event handlers
PowerDocu.GUI/PowerDocu.GUI.csproj Changed SDK from WindowsDesktop to standard .NET SDK
PowerDocu.GUI/CommandLineOptions.cs Enabled nullable reference types
PowerDocu.FlowDocumenter/PowerDocu.FlowDocumenter.csproj Changed target framework to net8.0-windows
PowerDocu.FlowDocumenter/FlowWordDocBuilder.cs Removed unused debug variable
PowerDocu.FlowDocumenter/FlowMarkdownBuilder.cs Removed unused debug variable
PowerDocu.AppDocumenter/PowerDocu.AppDocumenter.csproj Changed target framework to net8.0-windows
PowerDocu.AppDocumenter/AppWordDocBuilder.cs Removed unused exception variable

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@@ -1,4 +1,4 @@
<Project Sdk="Microsoft.NET.Sdk.WindowsDesktop">
<Project Sdk="Microsoft.NET.Sdk">
Copy link

Copilot AI Feb 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing from Microsoft.NET.Sdk.WindowsDesktop to Microsoft.NET.Sdk may cause build issues or loss of Windows-specific features. The WindowsDesktop SDK provides additional functionality for WPF and WinForms applications. Verify that all Windows-specific features still work correctly with the standard SDK, or consider keeping the WindowsDesktop SDK while using the net8.0-windows target framework.

Suggested change
<Project Sdk="Microsoft.NET.Sdk">
<Project Sdk="Microsoft.NET.Sdk.WindowsDesktop">

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants