-
Notifications
You must be signed in to change notification settings - Fork 30
Fix STM32 remapped GPIO data #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Is this really what we want? We would like to have a |
Ah, I may have misunderstood something here, let me check the raw data. |
Yeah, I think your right. This is wrong, because the GPIOs are filtered by the package id, and now I've just removed them. There is an issue with the merging algorithm, which doesn't work correctly in some complex cases where just one device has something, and the other do not. |
I can revert these changes, but then it's just broken in other ways, so I guess I have to fix this merging issue, which is completely unrelated. This issue is also holding up #35. |
Ah, no this is an issue in the raw data, there are simply multiple PA9 pins on different pin positions at the same time? (from <Pin Name="PA9" Position="19" Type="I/O">
<Signal Name="DAC1_EXTI9"/>
<Signal Name="I2C1_SCL"/>
<Signal Name="RCC_MCO"/>
<Signal Name="SPI2_MISO"/>
<Signal Name="TIM15_BK"/>
<Signal Name="TIM1_CH2"/>
<Signal Name="UCPD1_DBCC1"/>
<Signal Name="USART1_TX"/>
<Signal IOModes="Input,Output,Analog,EVENTOUT,EXTI" Name="GPIO"/>
</Pin>
<Pin Name="UCPD1_DBCC1" Position="19" Type="MonoIO" Variant="PINREMAP">
<Signal Name="UCPD1_DBCC1"/>
</Pin>
<Pin Name="PA10" Position="21" Type="I/O">
<Signal Name="I2C1_SDA"/>
<Signal Name="SPI2_MOSI"/>
<Signal Name="TIM17_BK"/>
<Signal Name="TIM1_CH3"/>
<Signal Name="UCPD1_DBCC2"/>
<Signal Name="USART1_RX"/>
<Signal IOModes="Input,Output,Analog,EVENTOUT,EXTI" Name="GPIO"/>
</Pin>
<Pin Name="UCPD1_DBCC2" Position="21" Type="MonoIO" Variant="PINREMAP_10_12">
<Signal Name="UCPD1_DBCC2"/>
</Pin>
<Pin Name="PA11 [PA9]" Position="22" Type="I/O">
<Signal Name="ADC1_EXTI11"/>
<Signal Name="COMP1_OUT"/>
<Signal Name="I2C2_SCL"/>
<Signal Name="I2S1_MCK"/>
<Signal Name="SPI1_MISO"/>
<Signal Name="TIM1_BK2"/>
<Signal Name="TIM1_CH4"/>
<Signal Name="USART1_CTS"/>
<Signal Name="USART1_NSS"/>
<Signal IOModes="Input,Output,Analog,EXTI" Name="GPIO"/>
</Pin>
<Pin Name="PA9 [PA11]" Position="22" Type="I/O" Variant="PINREMAP">
<Signal Name="DAC1_EXTI9"/>
<Signal Name="I2C1_SCL"/>
<Signal Name="RCC_MCO"/>
<Signal Name="SPI2_MISO"/>
<Signal Name="TIM15_BK"/>
<Signal Name="TIM1_CH2"/>
<Signal Name="USART1_TX"/>
<Signal IOModes="Input,Output,Analog,EVENTOUT,EXTI" Name="GPIO"/>
</Pin>
<Pin Name="PA12 [PA10]" Position="23" Type="I/O">
<Signal Name="COMP2_OUT"/>
<Signal Name="I2C2_SDA"/>
<Signal Name="I2S1_SD"/>
<Signal Name="I2S_CKIN"/>
<Signal Name="SPI1_MOSI"/>
<Signal Name="TIM1_ETR"/>
<Signal Name="USART1_CK"/>
<Signal Name="USART1_DE"/>
<Signal Name="USART1_RTS"/>
<Signal IOModes="Input,Output,Analog,EXTI" Name="GPIO"/>
</Pin>
<Pin Name="PA10 [PA12]" Position="23" Type="I/O" Variant="PINREMAP_10_12">
<Signal Name="I2C1_SDA"/>
<Signal Name="SPI2_MOSI"/>
<Signal Name="TIM17_BK"/>
<Signal Name="TIM1_CH3"/>
<Signal Name="USART1_RX"/>
<Signal IOModes="Input,Output,Analog,EVENTOUT,EXTI" Name="GPIO"/>
</Pin> |
What I think ST means here, is that when you remap these pins:
BUT, there seems to additionally be some kind of variant dependency as well:
|
The remapped pins were duplicated inside the GPIO list, which lead to conflicting data.
The remapped pins should only be part of the package, not the GPIO data.