Skip to content

Commit 052637d

Browse files
authored
Fix file inputs on Gallery and Versions pages not being selectable with keyboard (#4312)
1 parent c1a092e commit 052637d

File tree

4 files changed

+17
-101
lines changed

4 files changed

+17
-101
lines changed

apps/frontend/src/components/ui/DropArea.vue

Lines changed: 0 additions & 94 deletions
This file was deleted.

apps/frontend/src/pages/[type]/[id]/gallery.vue

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -295,11 +295,14 @@ import {
295295
UploadIcon,
296296
XIcon,
297297
} from '@modrinth/assets'
298-
import { ConfirmModal, injectNotificationManager } from '@modrinth/ui'
298+
import {
299+
ConfirmModal,
300+
DropArea,
301+
FileInput,
302+
injectNotificationManager,
303+
NewModal as Modal,
304+
} from '@modrinth/ui'
299305
300-
import DropArea from '~/components/ui/DropArea.vue'
301-
import FileInput from '~/components/ui/FileInput.vue'
302-
import Modal from '~/components/ui/Modal.vue'
303306
import { isPermission } from '~/utils/permissions.ts'
304307
305308
const props = defineProps({
@@ -765,7 +768,6 @@ export default defineNuxtComponent({
765768
}
766769
767770
.modal-gallery {
768-
padding: var(--spacing-card-bg);
769771
display: flex;
770772
flex-direction: column;
771773

apps/frontend/src/pages/[type]/[id]/versions.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -195,12 +195,12 @@ import {
195195
import {
196196
ButtonStyled,
197197
ConfirmModal,
198+
DropArea,
198199
FileInput,
199200
OverflowMenu,
200201
ProjectPageVersions,
201202
} from '@modrinth/ui'
202203
203-
import DropArea from '~/components/ui/DropArea.vue'
204204
import { acceptFileFromProjectType } from '~/helpers/fileUtils.js'
205205
import { isPermission } from '~/utils/permissions.ts'
206206
import { reportVersion } from '~/utils/report-helpers.ts'

packages/ui/src/components/base/FileInput.vue

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,11 +85,19 @@ export default defineComponent({
8585
label {
8686
flex-direction: unset;
8787
max-height: unset;
88+
&:focus-within {
89+
outline: 0.25rem solid #ea80ff;
90+
}
91+
8892
svg {
8993
height: 1rem;
9094
}
9195
input {
92-
display: none;
96+
position: absolute;
97+
height: 1px;
98+
width: 1px;
99+
overflow: hidden;
100+
clip: rect(1px, 1px, 1px, 1px);
93101
}
94102
&.long-style {
95103
display: flex;

0 commit comments

Comments
 (0)