Skip to content

Commit 66d943d

Browse files
authored
fix(frontend): alt-text for flags (#2894)
Fixes #2397
1 parent f5f876e commit 66d943d

File tree

1 file changed

+28
-18
lines changed

1 file changed

+28
-18
lines changed

apps/frontend/src/components/ui/charts/ChartDisplay.vue

Lines changed: 28 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -192,15 +192,20 @@
192192
class="country-value"
193193
>
194194
<div class="country-flag-container">
195-
<img
196-
:src="
197-
name.toLowerCase() === 'xx' || !name
198-
? 'https://cdn.modrinth.com/placeholder-banner.svg'
199-
: countryCodeToFlag(name)
200-
"
201-
alt="Hidden country"
202-
class="country-flag"
203-
/>
195+
<template v-if="name.toLowerCase() === 'xx' || !name">
196+
<img
197+
src="https://cdn.modrinth.com/placeholder-banner.svg"
198+
alt="Placeholder flag"
199+
class="country-flag"
200+
/>
201+
</template>
202+
<template v-else>
203+
<img
204+
:src="countryCodeToFlag(name)"
205+
:alt="`${countryCodeToName(name)}'s flag`"
206+
class="country-flag"
207+
/>
208+
</template>
204209
</div>
205210
<div class="country-text">
206211
<strong class="country-name"
@@ -246,15 +251,20 @@
246251
class="country-value"
247252
>
248253
<div class="country-flag-container">
249-
<img
250-
:src="
251-
name.toLowerCase() === 'xx' || !name
252-
? 'https://cdn.modrinth.com/placeholder-banner.svg'
253-
: countryCodeToFlag(name)
254-
"
255-
alt="Hidden country"
256-
class="country-flag"
257-
/>
254+
<template v-if="name.toLowerCase() === 'xx' || !name">
255+
<img
256+
src="https://cdn.modrinth.com/placeholder-banner.svg"
257+
alt="Placeholder flag"
258+
class="country-flag"
259+
/>
260+
</template>
261+
<template v-else>
262+
<img
263+
:src="countryCodeToFlag(name)"
264+
:alt="`${countryCodeToName(name)}'s flag`"
265+
class="country-flag"
266+
/>
267+
</template>
258268
</div>
259269
<div class="country-text">
260270
<strong class="country-name">

0 commit comments

Comments
 (0)