refactor: move .env to .env.example #2883
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piprett
added a commit
to Erb3/modrinth
that referenced
this pull request
Nov 3, 2024
This will help setting up labrinth for local development. You can now use a mock SMTP server such as smtp4dev. The TLS options will stay the same as before if set to `true`, and disabled when `false`. Depends on modrinth#2883
|
This is just sitting here making conflicts. Prioritizing #2886 for the time being. Please re-open when you (staff) are interested in reviewing/merging |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 22, 2025
* refactor: move .env to .env.example * refactor(labrinth): allow setting SMTP port and TLS This will help setting up labrinth for local development. You can now use a mock SMTP server such as smtp4dev. The TLS options will stay the same as before if set to `true`, and disabled when `false`. Depends on #2883 * chore(labrinth): lint * chore(labrinth): conflicts * chore(labrinth): conflicts * fix: use TLS port by default Co-authored-by: AlexTMjugador<me@alegon.dev> Co-authored-by: Alejandro González <7822554+AlexTMjugador@users.noreply.github.com> Signed-off-by: Erb3 <49862976+Erb3@users.noreply.github.com> * fix(labrinth): correct deafult SMTP port in .env * feat(labrinth): expose all SMTP TLS settings Replaced if/else with a switch statement. The new values for `SMPT_TLS` are `none`, `opportunistic_start_tls`, `requires_start_tls`, `tls`. When none of these values are supplied, it defaults to full TLS (`tls`), and throws a warning. Resolves PR review * fix(labrinth): correct SMTP TLS example .env setting Signed-off-by: Erb3 <49862976+Erb3@users.noreply.github.com> * fix(labrinth) SMTP tls env var check Co-authored-by: Alejandro González <7822554+AlexTMjugador@users.noreply.github.com> Signed-off-by: Erb3 <49862976+Erb3@users.noreply.github.com> --------- Signed-off-by: Erb3 <49862976+Erb3@users.noreply.github.com> Co-authored-by: Alejandro González <7822554+AlexTMjugador@users.noreply.github.com>
|
Hi @Erb3, I think this PR is also pretty helpful, thanks for putting it together! Would you mind updating it so it's ready to merge? Much appreciated! ❤️ |
|
Superseded by #3592 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved
.envfiles to.env.examplefiles. Checked them out of git,.envis already in the root.gitignore. It's annoying to work with.envfiles checked in, they make it a lot easier to leak credentials, and harder to pull upstream.