Skip to content

Files UX Sprint #3019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 59 commits into from
Dec 16, 2024
Merged

Files UX Sprint #3019

merged 59 commits into from
Dec 16, 2024

Conversation

ferothefox
Copy link
Contributor

@ferothefox ferothefox commented Dec 14, 2024 •
edited
Loading

This PR is part of the Modrinth Servers January Release

New

  • Drag and drop anything in the file manager
  • New file upload queue status bar
  • Parallel file uploads
  • Ability to cancel in-progress file uploads
  • Creation dates are now displayed
  • Ability to sort by most recently created files
  • YAML and TOML now support syntax highlighting
  • Find and replace support in files editor

Improved

  • Files list renders up to 200% faster
  • Image viewer performance improvements, improved UI, and better handling of large-to-display images
  • Localization fixes
  • UI inconsistency fixes
  • [internal]: file operations are now typed

@ferothefox
chore: dedupe lockfile
8a3ab94 
Signed-off-by: Evan Song <theevansong@gmail.com>
@ferothefox
fix: incorrect spacing between editing and browsing state
f69c15d 
Signed-off-by: Evan Song <theevansong@gmail.com>
@ferothefox
chore: improve files image viewer toolbar
e3819ea 
Signed-off-by: Evan Song <theevansong@gmail.com>
@ferothefox
chore: image viewer cursor affordance
77e9db4 
Signed-off-by: Evan Song <theevansong@gmail.com>
@ferothefox
chore: clean imports
3da4a45 
Signed-off-by: Evan Song <theevansong@gmail.com>
@ferothefox
chore: add tooltips
183cbb5 
Signed-off-by: Evan Song <theevansong@gmail.com>
@ferothefox
chore: use black background
80b0a95 
Signed-off-by: Evan Song <theevansong@gmail.com>
@ferothefox
feat: show scale factor, handle large images, consolidate state
3d66082 
Signed-off-by: Evan Song <theevansong@gmail.com>
@ferothefox
chore: add types to fs operations
13f3a43 
Signed-off-by: Evan Song <theevansong@gmail.com>
@ferothefox
feat: add date create sorting option
3b3e9b5 
Signed-off-by: Evan Song <theevansong@gmail.com>
@ferothefox
fix: match name of folder creation modal
172c131 
Signed-off-by: Evan Song <theevansong@gmail.com>
@ferothefox
fix: add it here too
ffd01f2 
Signed-off-by: Evan Song <theevansong@gmail.com>
@ferothefox
feat: add creation date to file item, file manager header
7b5f811 
Signed-off-by: Evan Song <theevansong@gmail.com>
@ferothefox
chore: a11y
e7057eb 
Signed-off-by: Evan Song <theevansong@gmail.com>
@ferothefox
fix: ensure move item modal always has leading slash
bcbd069 
Signed-off-by: Evan Song <theevansong@gmail.com>
@ferothefox
fix: correct move input placeholder
5381562 
Signed-off-by: Evan Song <theevansong@gmail.com>
@ferothefox
chore: correct design disparity
c6361b1 
Signed-off-by: Evan Song <theevansong@gmail.com>
@ferothefox
chore: add better affordance on active file item state
e24bd5f 
Signed-off-by: Evan Song <theevansong@gmail.com>
@ferothefox
fix: correct instances where we dont sentence case
59a3185 
Signed-off-by: Evan Song <theevansong@gmail.com>
@ferothefox
chore: clean
8549991 
Signed-off-by: Evan Song <theevansong@gmail.com>
@ferothefox
chore: notify that server restarted on saveandrestart
f2199d6 
Signed-off-by: Evan Song <theevansong@gmail.com>
@ferothefox
fix: consolidate error state in file manager
9cea408 
Signed-off-by: Evan Song <theevansong@gmail.com>
@ferothefox
chore: adjust sizing
445fa56 
Signed-off-by: Evan Song <theevansong@gmail.com>
@ferothefox
feat: drag and drop file items to move them
afbd7af 
Signed-off-by: Evan Song <theevansong@gmail.com>
@ferothefox
feat: enable ability to drag folders too
ceb4336 
Signed-off-by: Evan Song <theevansong@gmail.com>
@ferothefox
feat: better file movement toasts
d04a25c 
Signed-off-by: Evan Song <theevansong@gmail.com>
@ferothefox
just say u hate me
ad18e1e 
Signed-off-by: Evan Song <theevansong@gmail.com>
@ferothefox
feat: uploading indicator for file uploads
3322582 
Signed-off-by: Evan Song <theevansong@gmail.com>
@ferothefox
chore: cleaner file item ghost when dragging
1cfa85a 
Signed-off-by: Evan Song <theevansong@gmail.com>
@ferothefox
fix: enforce max length and truncate on ghost
69b9fc1 
Signed-off-by: Evan Song <theevansong@gmail.com>
ferothefox and others added 13 commits December 14, 2024 13:06
@ferothefox
chore: actually handle case with multiple dots in file name before se…
8677784 
…tting language

Signed-off-by: Evan Song <theevansong@gmail.com>
@ferothefox
Merge branch 'modrinth:main' into evan/files-ux-improvements-1
9d45f15
@ferothefox
fix: match move icons in file context/threedot
af29d0d 
Signed-off-by: Evan Song <theevansong@gmail.com>
@ferothefox
feat: upload indicator
fbbc411 
Signed-off-by: Evan Song <theevansong@gmail.com>
@ferothefox
Merge remote-tracking branch 'origin/main' into evan/files-ux-improve…
fca3a6c 
…ments-1

Signed-off-by: Evan Song <theevansong@gmail.com>
@ferothefox
chore: dedupe lockfile again
135eb85 
Signed-off-by: Evan Song <theevansong@gmail.com>
@ferothefox
Merge remote-tracking branch 'origin/main' into evan/files-ux-improve…
c0202a2 
…ments-1

Signed-off-by: Evan Song <theevansong@gmail.com>
@ferothefox
lockfile
4c6b2c2 
Signed-off-by: Evan Song <theevansong@gmail.com>
@ferothefox
fix: file undefinedness
e427f79 
Signed-off-by: Evan Song <theevansong@gmail.com>
@ferothefox
Merge branch 'modrinth:main' into evan/files-ux-improvements-1
6b6b4b6
@ferothefox
Merge branch 'modrinth:main' into evan/files-ux-improvements-1
41ea17b
@ferothefox
Merge branch 'modrinth:main' into evan/files-ux-improvements-1
b72729e
@ferothefox
Merge branch 'modrinth:main' into evan/files-ux-improvements-1
f015ba2
@zefir-git
Copy link
Contributor

Suggestion: show the full file upload queue together with an ❌ button to cancel uploading.
I.e. something similar to:
image

https://play.tailwindcss.com/9IyYQwlzIN

For uploading, instead of XHR, perhaps consider Fetch API together with AbortSignal in the RequestInit for cancelling.

@ferothefox
checkpoint
427d3ca 
Signed-off-by: Evan Song <theevansong@gmail.com>
@ferothefox
checkpoint
ef7702c 
Signed-off-by: Evan Song <theevansong@gmail.com>
@ferothefox
checkpoint
8ae5bfa 
Signed-off-by: Evan Song <theevansong@gmail.com>
@ferothefox
remove shitty animation logic
24b77c4 
Signed-off-by: Evan Song <theevansong@gmail.com>
@ferothefox
feat: file upload queuer
6646de2 
Signed-off-by: Evan Song <theevansong@gmail.com>
@ferothefox
chore: only allow editable files to have active affordance
33c46c6 
Signed-off-by: Evan Song <theevansong@gmail.com>
@ferothefox
fix: properly throw pyrofetcherror when rename fails
c830826 
Signed-off-by: Evan Song <theevansong@gmail.com>
@ferothefox
feat: cancel file uploads
5d19948 
Signed-off-by: Evan Song <theevansong@gmail.com>
@ferothefox
Copy link
Contributor Author

@zefir-git Thank you for your feedback! The latest commits have landed an upload queue just like the concept you proposed and the ability to cancel file uploads.

@ferothefox ferothefox marked this pull request as ready for review December 16, 2024 06:08
@ferothefox
chore: clean
dce1e77 
Signed-off-by: Evan Song <theevansong@gmail.com>
@Geometrically Geometrically added this pull request to the merge queue Dec 16, 2024
Merged via the queue into modrinth:main with commit fee8d6c Dec 16, 2024
1 check passed
@ferothefox ferothefox deleted the evan/files-ux-improvements-1 branch December 20, 2024 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Geometrically Geometrically Geometrically approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ferothefox @zefir-git @Geometrically