Skip to content

Conversation

worldwidepixel
Copy link
Contributor

Many changes, all vaguely related to the main goal of making Collections visually consistent with the rest of the platform.

These include:

  • Modal for editing collections (for both frontend and app)
  • Redesigned modal for sharing collections (with Bluesky support!)
  • Option to share collections from page
  • Revamped collections page that follows design standard set by user, project, and organisation pages.

While I hope this meets expectations for a Modrinth PR, suggestions for improvement are always warmly welcome.

<3 WWP

saveChanges();
} catch {
console.error("uhh.... This isn't good.");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should throw the error into a notification pop-up.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot to remove that dev logging, will fix! (I was rather lucky on implementation and didn't run into it)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest commit should resolve this.

@worldwidepixel worldwidepixel requested a review from IMB11 February 15, 2025 21:07
@worldwidepixel
Copy link
Contributor Author

New addition- collections are now sorted by creation date. Did this because randomly sorted collections feel rather haphazard.

Here's a good visual aid to help my point of doing it:
image

@Prospector
Copy link
Member

Redesigning collections will introduce conflicts or redundancies with the app-users-orgs-and-more branch, so I would say avoid that for now. There's a lot of random pieces touched by this PR, I might suggest splitting them into more individual PRs since it could make them easier to review and merge piece-by-piece.

Primarily, with redesigning the collection pages, I would either base it on app-users-orgs-and-more or scrap that for now, since that will come with that branch one way or another.

The sorting of the collections on user pages is something that could be merged relatively quickly, however it's trapped in this PR with a bunch of other stuff that isn't quite ready yet.

@worldwidepixel
Copy link
Contributor Author

This PR definitely grew rather large quickly as I realised that updating a collections page would take more than one file.

The sort of recursive updating-chaining as "Collections editing should be done via modal, new modal created in the UI library, oh perhaps sharing should finally be implemented, so let's update that and add Bluesky which also means that the logo needs to be added to the assets library"

I will attempt to split this into multiple sub-PRs over the next few days, depending on what is possible.
(and taking a look at the app's version of collections- I actually got pretty close for just guessing!)

@worldwidepixel
Copy link
Contributor Author

This PR will be closed when all changes have been moved to their proper homes- starting with #3286 which fixes collection sorting on user pages and in dashboard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants