-
Notifications
You must be signed in to change notification settings - Fork 337
feat(frontend): Redesign Collections (web), update share modal (shared), add collections edit modal (shared) #3262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(frontend): Redesign Collections (web), update share modal (shared), add collections edit modal (shared) #3262
Conversation
saveChanges(); | ||
} catch { | ||
console.error("uhh.... This isn't good."); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should throw the error into a notification pop-up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I forgot to remove that dev logging, will fix! (I was rather lucky on implementation and didn't run into it)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Latest commit should resolve this.
…rovements in relation to collections
Redesigning collections will introduce conflicts or redundancies with the Primarily, with redesigning the collection pages, I would either base it on The sorting of the collections on user pages is something that could be merged relatively quickly, however it's trapped in this PR with a bunch of other stuff that isn't quite ready yet. |
This PR definitely grew rather large quickly as I realised that updating a collections page would take more than one file. The sort of recursive updating-chaining as "Collections editing should be done via modal, new modal created in the UI library, oh perhaps sharing should finally be implemented, so let's update that and add Bluesky which also means that the logo needs to be added to the assets library" I will attempt to split this into multiple sub-PRs over the next few days, depending on what is possible. |
This PR will be closed when all changes have been moved to their proper homes- starting with #3286 which fixes collection sorting on user pages and in dashboard |
Many changes, all vaguely related to the main goal of making Collections visually consistent with the rest of the platform.
These include:
While I hope this meets expectations for a Modrinth PR, suggestions for improvement are always warmly welcome.
<3 WWP