fix(theseus): make SQLx migration checksums match the deployed ones on Windows #3899
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexTMjugador
force-pushed
the
alex/theseus-migration-checksum-mismatch-fix
branch
from
f2901be to
a9a3df1
Compare
Prospector
approved these changes
Jul 5, 2025
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #3193 normalized the line endings of all text files to LF, which is a very positive change overall. However, SQLx migration scripts are sensitive to line ending differences for reasons explained in the diff of the PR, and previous Windows releases of the application were built in environments where these scripts used CRLF line endings, causing misleading migration modification errors such as
Error while applying migrations: migration 20240711194701 was previously applied but has been modifiedwhen switching to a build that uses migration scripts with LF line endings.This PR implements the most practical compromise I could come up with to avoid breaking database migrations across the application's wide deployment: restoring the previous default Git behavior on line endings for the affected migration files.
TODO