Skip to content

fix(app): properly show all versions and notify loaders #4395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 20, 2025
Merged

fix(app): properly show all versions and notify loaders #4395

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c56f1e0
fix(app): properly show all versions and notify loaders
teaSummer Sep 20, 2025
12f1904
fix lint
teaSummer Sep 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions apps/frontend/src/components/ui/NotificationItem.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@
<span class="version-info">
for
<Categories
:categories="loaderCategories"
:categories="getLoaderCategories(notif.extra_data.version)"
:type="notif.extra_data.project.project_type"
class="categories"
/>
Expand Down Expand Up @@ -391,12 +391,6 @@ const user = computed(() => props.notification.extra_data.user)
const organization = computed(() => props.notification.extra_data.organization)
const invitedBy = computed(() => props.notification.extra_data.invited_by)

const loaderCategories = computed(() => {
return tags.value.loaders.filter((loader) => {
return version.value?.loaders?.includes(loader.name)
})
})

const threadLink = computed(() => {
if (report.value) {
return `/dashboard/report/${report.value.id}`
Expand Down Expand Up @@ -462,6 +456,12 @@ function getMessages() {
}
return messages
}

function getLoaderCategories(ver) {
return tags.value.loaders.filter((loader) => {
return ver?.loaders?.includes(loader.name)
})
}
</script>

<style lang="scss" scoped>
Expand Down
6 changes: 6 additions & 0 deletions apps/frontend/src/pages/[type]/[id].vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1664,6 +1664,12 @@ if (!route.name.startsWith('type-id-settings')) {
const onUserCollectProject = useClientTry(userCollectProject)

const { version, loader } = route.query
if (
project.value.game_versions.length > 0 &&
project.value.game_versions.every((v) => v.includes('w') || v.includes('-'))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this isn't how this should be checked, the release type should be checked in the tags list.

also, it doesn't seem like this hides the check box or anything?

) {
showAllVersions.value = true
}
if (version !== undefined && project.value.game_versions.includes(version)) {
userSelectedGameVersion.value = version
}
Expand Down