Merge pull request #2268 from TFBW/fix-issue-2220

mergify[bot] · web-flow · commit 990d344ef855 · 2025-07-31T21:12:12.000Z
Fix memory leak in AWAIT_ON_READY
diff --git a/lib/Mojo/Promise.pm b/lib/Mojo/Promise.pm
@@ -37,7 +37,9 @@ sub AWAIT_NEW_FAIL { _await('reject',  @_) }
 sub AWAIT_ON_CANCEL { }
 
 sub AWAIT_ON_READY {
-  shift->_finally(0, @_)->catch(sub { });
+  my ($self, $cb) = @_;
+  push @{$self->{resolve}}, $cb;
+  push @{$self->{reject}},  $cb;
 }
 
 sub AWAIT_WAIT {

Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,9 @@ sub AWAIT_NEW_FAIL { _await('reject', @_) }`
`37`	`37`	`sub AWAIT_ON_CANCEL { }`
`38`	`38`
`39`	`39`	`sub AWAIT_ON_READY {`
`40`		`- shift->_finally(0, @_)->catch(sub { });`
	`40`	`+ my ($self, $cb) = @_;`
	`41`	`+ push @{$self->{resolve}}, $cb;`
	`42`	`+ push @{$self->{reject}}, $cb;`
`41`	`43`	`}`
`42`	`44`
`43`	`45`	`sub AWAIT_WAIT {`