Skip to content

Commit bf6ca73

Browse files
committed
convert t/mojolicious/log_lite_app.t to use subtests
1 parent 4153dc2 commit bf6ca73

File tree

1 file changed

+32
-28
lines changed

1 file changed

+32
-28
lines changed

t/mojolicious/log_lite_app.t

Lines changed: 32 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -23,33 +23,37 @@ get '/simple' => sub {
2323

2424
my $t = Test::Mojo->new;
2525

26-
# Simple log messages with and without context
27-
my $buffer = '';
28-
open my $handle, '>', \$buffer;
29-
$t->app->log(Mojo::Log->new(handle => $handle));
30-
$t->get_ok('/simple')->status_is(200)->content_is('Simple!');
31-
like $buffer, qr/First.*Second.*Third.*No context!.*Fourth.*Fifth/s, 'right order';
32-
like $buffer, qr/\[.+\] \[\d+\] \[debug\] \[17a60115\] First!/, 'message with request id';
33-
like $buffer, qr/\[.+\] \[\d+\] \[info\] \[17a60115\] Second! Third!/s, 'message with request id';
34-
like $buffer, qr/\[.+\] \[\d+\] \[debug\] No context!/, 'message without request id';
35-
like $buffer, qr/\[.+\] \[\d+\] \[warn\] \[17a60115\] Fourth! Fifth!/s, 'message with request id';
36-
37-
# Concurrent requests
38-
$buffer = '';
39-
my $first = $t->app->build_controller;
40-
$first->req->request_id('123-first');
41-
my $second = $t->app->build_controller;
42-
$second->req->request_id('123-second');
43-
$first->log->debug('First!');
44-
$second->log->debug('Second!');
45-
$first->log->debug('Third!');
46-
$second->log->debug('Fourth!');
47-
$t->app->log->debug('Fifth!');
48-
like $buffer, qr/First.*Second.*Third.*Fourth.*Fifth/s, 'right order';
49-
like $buffer, qr/\[.+\] \[\d+\] \[debug\] \[123-first\] First!/, 'message with request id';
50-
like $buffer, qr/\[.+\] \[\d+\] \[debug\] \[123-second\] Second!/, 'message with request id';
51-
like $buffer, qr/\[.+\] \[\d+\] \[debug\] \[123-first\] Third!/, 'message with request id';
52-
like $buffer, qr/\[.+\] \[\d+\] \[debug\] \[123-second\] Fourth!/, 'message with request id';
53-
like $buffer, qr/\[.+\] \[\d+\] \[debug\] Fifth!/, 'message without request id';
26+
subtest 'Simple log messages with and without context' => sub {
27+
my $buffer = '';
28+
open my $handle, '>', \$buffer;
29+
$t->app->log(Mojo::Log->new(handle => $handle));
30+
$t->get_ok('/simple')->status_is(200)->content_is('Simple!');
31+
like $buffer, qr/First.*Second.*Third.*No context!.*Fourth.*Fifth/s, 'right order';
32+
like $buffer, qr/\[.+\] \[\d+\] \[debug\] \[17a60115\] First!/, 'message with request id';
33+
like $buffer, qr/\[.+\] \[\d+\] \[info\] \[17a60115\] Second! Third!/s, 'message with request id';
34+
like $buffer, qr/\[.+\] \[\d+\] \[debug\] No context!/, 'message without request id';
35+
like $buffer, qr/\[.+\] \[\d+\] \[warn\] \[17a60115\] Fourth! Fifth!/s, 'message with request id';
36+
};
37+
38+
subtest 'Concurrent requests' => sub {
39+
my $buffer = '';
40+
open my $handle, '>', \$buffer;
41+
$t->app->log(Mojo::Log->new(handle => $handle));
42+
my $first = $t->app->build_controller;
43+
$first->req->request_id('123-first');
44+
my $second = $t->app->build_controller;
45+
$second->req->request_id('123-second');
46+
$first->log->debug('First!');
47+
$second->log->debug('Second!');
48+
$first->log->debug('Third!');
49+
$second->log->debug('Fourth!');
50+
$t->app->log->debug('Fifth!');
51+
like $buffer, qr/First.*Second.*Third.*Fourth.*Fifth/s, 'right order';
52+
like $buffer, qr/\[.+\] \[\d+\] \[debug\] \[123-first\] First!/, 'message with request id';
53+
like $buffer, qr/\[.+\] \[\d+\] \[debug\] \[123-second\] Second!/, 'message with request id';
54+
like $buffer, qr/\[.+\] \[\d+\] \[debug\] \[123-first\] Third!/, 'message with request id';
55+
like $buffer, qr/\[.+\] \[\d+\] \[debug\] \[123-second\] Fourth!/, 'message with request id';
56+
like $buffer, qr/\[.+\] \[\d+\] \[debug\] Fifth!/, 'message without request id';
57+
};
5458

5559
done_testing();

0 commit comments

Comments
 (0)