Skip to content

Conversation

kraih
Copy link
Member

@kraih kraih commented Apr 11, 2025

Alternative to #2243. Personally, i think i prefer this solution.

@kraih kraih requested review from a team, Grinnz, Copilot, jberger, jhthorsen and marcusramberg April 11, 2025 17:02
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (5)
  • lib/Mojo/File.pm: Language not supported
  • lib/Mojo/UserAgent/Transactor.pm: Language not supported
  • lib/Mojolicious/Guides/Cookbook.pod: Language not supported
  • t/mojo/file_download.t: Language not supported
  • t/mojo/transactor.t: Language not supported

@kraih
Copy link
Member Author

kraih commented Apr 11, 2025

I'm voting for this one. 👍

Copy link
Member

@christopherraa christopherraa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To me this looks good, and it seems like a good addition to the user agent / transactor. Only thing I noticed was a small type. Added a suggested fix for that.

@kraih kraih force-pushed the downloader_file branch 2 times, most recently from e4275de to b012327 Compare April 11, 2025 17:43
@kraih kraih force-pushed the downloader_file branch from b012327 to f141b01 Compare April 11, 2025 18:02
@kraih kraih merged commit 4153dc2 into main Apr 14, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants