Skip to content

Fix memory leak in AWAIT_ON_READY #2268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 31, 2025
Merged

Fix memory leak in AWAIT_ON_READY #2268

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/Mojo/Promise.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,9 @@ sub AWAIT_NEW_FAIL { _await('reject', @_) }
sub AWAIT_ON_CANCEL { }

sub AWAIT_ON_READY {
shift->_finally(0, @_)->catch(sub { });
my ($self, $cb) = @_;
push @{$self->{resolve}}, $cb;
push @{$self->{reject}}, $cb;
}

sub AWAIT_WAIT {
Expand Down
Loading