Migrate from Scrivener to Flop for pagination, filtering, and sorting #523
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the migration from Scrivener to Flop for pagination, filtering, and sorting in Torch. Flop provides more advanced features while maintaining backward compatibility with existing Scrivener-based code.
Changes
Torch.FlopAdapter
module to bridge between Scrivener and Flop APIsTorch.Helpers.paginate/4
to use Flop internallyTorch.Pagination
module to use Flop while maintaining backward compatibilityTorch.PaginationView.pagination_from_meta/2
Torch.TableView.flop_table_link/3
Backward Compatibility
This migration is designed to be backward compatible. Existing code that uses Torch's pagination should continue to work without changes. The following functions maintain backward compatibility:
Torch.Helpers.paginate/4
Torch.Pagination
moduleTorch.PaginationView.pagination/1
New Features
Flop provides several advanced features not available in Scrivener:
Documentation
Closes #479
💻 View my work • About Codegen