PIPRES-539 add line items payments api #1133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GytisZum
requested changes
Jun 30, 2025
| @@ -86,7 +86,8 @@ public function testGetCartLines( | |||
| $shippingCost, | |||
| $cartItems, | |||
| $psGiftWrapping, | |||
| $selectedVoucherCategory | |||
| $selectedVoucherCategory, | |||
| 'OrderLine' | |||
There was a problem hiding this comment.
I have seen these 'hardcoded' values n multiple files, I suggest to move them into the constants
src/Service/CartLinesService.php
Outdated
| * | ||
| * @return array | ||
| */ | ||
| private function convertToLineArray(array $newItems, $currencyIsoCode, $apiRoundingPrecision) | ||
| private function convertToLineArray(array $newItems, $currencyIsoCode, $apiRoundingPrecision, $lineType) |
There was a problem hiding this comment.
Suggested change
| private function convertToLineArray(array $newItems, $currencyIsoCode, $apiRoundingPrecision, $lineType) | |
| private function convertToLineArray(array $newItems, string $currencyIsoCode, int $apiRoundingPrecision, string $lineType): array |
| exit; | ||
| } | ||
|
|
||
| class PaymentLine implements JsonSerializable |
There was a problem hiding this comment.
parameters and return types
| @@ -360,14 +375,67 @@ public function setEmail($email) | |||
| $this->email = $email; | |||
| } | |||
|
|
|||
| public function jsonSerialize() | |||
| /** | |||
| * @return PaymentLine[] | |||
There was a problem hiding this comment.
Parameters and return types
|
|
||
| switch ($lineType) { | ||
| case 'OrderLine': | ||
| $line->setName($item['name'] ?: $item['sku']); |
There was a problem hiding this comment.
$item['name'] make sure that you have correct product name by cart language
There was a problem hiding this comment.
That products are retrieved by $cart->getProducts()
…PrestaShop into PIPRES-600/multiple-vouchers
…PrestaShop into PIPRES-600/multiple-vouchers
…PrestaShop into PIPRES-600/multiple-vouchers
…9/add-line-items-payments-api
…ollie/PrestaShop into PIPRES-539/captures-api
…p into PIPRES-601/react-removal
…op into PIPRES-601/redesign-admin-orders
…PrestaShop into PIPRES-600/multiple-vouchers
PIPRES-600 multiple vouchers
PIPRES-601 Re-design Mollie Admin Orders
PIPRES-601 React removal
PIPRES-539 captures api
MarijusDilys
changed the base branch from
develop
to
PIPRES-645/backoffice-redesign-main
MarijusDilys
merged commit a7253a5
into
PIPRES-645/backoffice-redesign-main
5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Line.phpintoOrderLineandPaymentLinefor compatibility issues, after fully transform to Payments API,OrderLineDTO will be removed. All payments methods working except "Vouchers" in Payments API, all data is being sent correctly. Removed payments methods for restrictions only for Orders API, now all payments methods can be used for both