MOL-363: update naming

Author: tdang1-shopmacher

processor/src/commercetools/action.commercetools.ts

@@ -29,21 +29,21 @@ export const setCustomFields = (fieldName: string, fieldValue: string) => {
  * If the responseValue is an API response, JSON Stringify it before passing it
  */
 export const addInterfaceInteraction = (params: CreateInterfaceInteractionParams) => {
-  const { sctmActionType, sctmRequest, sctmResponse, sctmId, sctmCreatedAt } = params;
-  const interfaceInteractionId = sctmId ? sctmId : uuid();
-  const interfaceInteractionTimestamp = sctmCreatedAt ? sctmCreatedAt : createDateNowString();
+  const { sctm_action_type, sctm_request, sctm_response, sctm_id, sctm_created_at } = params;
+  const interfaceInteractionId = sctm_id ? sctm_id : uuid();
+  const interfaceInteractionTimestamp = sctm_created_at ? sctm_created_at : createDateNowString();
 
   return {
     action: 'addInterfaceInteraction',
     type: {
       key: CustomFields.createPayment.interfaceInteraction.key,
     },
     fields: {
-      sctmId: interfaceInteractionId,
-      sctmActionType,
-      sctmCreatedAt: interfaceInteractionTimestamp,
-      sctmRequest: sctmRequest,
-      sctmResponse: sctmResponse,
+      sctm_id: interfaceInteractionId,
+      sctm_action_type,
+      sctm_created_at: interfaceInteractionTimestamp,
+      sctm_request: sctm_request,
+      sctm_response: sctm_response,
     },
   };
 };

processor/src/service/payment.service.ts

@@ -309,11 +309,11 @@ export const getCreatePaymentUpdateAction = async (molliePayment: MPayment | Cus
     };
 
     const interfaceInteractionParams = {
-      sctmActionType: ConnectorActions.CreatePayment,
-      sctmRequest: JSON.stringify(interfaceInteractionRequest),
-      sctmResponse: JSON.stringify(interfaceInteractionResponse),
-      sctmId: uuid(),
-      sctmCreatedAt: molliePayment.createdAt,
+      sctm_action_type: ConnectorActions.CreatePayment,
+      sctm_request: JSON.stringify(interfaceInteractionRequest),
+      sctm_response: JSON.stringify(interfaceInteractionResponse),
+      sctm_id: uuid(),
+      sctm_created_at: molliePayment.createdAt,
     };
 
     return Promise.resolve([

processor/src/types/commercetools.types.ts

@@ -73,11 +73,11 @@ export type CTTransaction = {
 };
 
 export type CreateInterfaceInteractionParams = {
-  sctmActionType: ConnectorActions;
-  sctmRequest: string;
-  sctmResponse: string;
-  sctmId?: string;
-  sctmCreatedAt?: string;
+  sctm_action_type: ConnectorActions;
+  sctm_request: string;
+  sctm_response: string;
+  sctm_id?: string;
+  sctm_created_at?: string;
 };
 
 export type Action = {

processor/src/utils/constant.utils.ts

@@ -23,11 +23,11 @@ export const CustomFields = {
     interfaceInteraction: {
       key: 'sctm_interface_interaction_type',
       fields: {
-        id: 'sctmId',
-        actionType: 'sctmActionType',
-        createdAt: 'sctmCreatedAt',
-        request: 'sctmRequest',
-        response: 'sctmResponse',
+        id: 'sctm_id',
+        actionType: 'sctm_action_type',
+        createdAt: 'sctm_created_at',
+        request: 'sctm_request',
+        response: 'sctm_response',
       },
     },
   },

processor/tests/commercetools/action.commercetools.spec.ts

@@ -59,11 +59,11 @@ describe('Test actions.utils.ts', () => {
     };
 
     const params: CreateInterfaceInteractionParams = {
-      sctmId: '123456789',
-      sctmActionType: ConnectorActions.CreatePayment,
-      sctmRequest: JSON.stringify(requestValueObject),
-      sctmResponse: JSON.stringify(responseValueObject),
-      sctmCreatedAt: '2024-07-04T14:07:35+00:00',
+      sctm_id: '123456789',
+      sctm_action_type: ConnectorActions.CreatePayment,
+      sctm_request: JSON.stringify(requestValueObject),
+      sctm_response: JSON.stringify(responseValueObject),
+      sctm_created_at: '2024-07-04T14:07:35+00:00',
     };
 
     const actual = addInterfaceInteraction(params);
@@ -74,11 +74,11 @@ describe('Test actions.utils.ts', () => {
         key: 'sctm_interface_interaction_type',
       },
       fields: {
-        sctmId: params.sctmId,
-        sctmActionType: params.sctmActionType,
-        sctmCreatedAt: params.sctmCreatedAt,
-        sctmRequest: params.sctmRequest,
-        sctmResponse: params.sctmResponse,
+        sctm_id: params.sctm_id,
+        sctm_action_type: params.sctm_action_type,
+        sctm_created_at: params.sctm_created_at,
+        sctm_request: params.sctm_request,
+        sctm_response: params.sctm_response,
       },
     });
   });

processor/tests/service/payment.service.spec.ts

@@ -528,14 +528,14 @@ describe('Test getCreatePaymentUpdateAction', () => {
         key: 'sctm_interface_interaction_type',
       },
       fields: {
-        sctmId: uuid,
-        sctmActionType: ConnectorActions.CreatePayment,
-        sctmCreatedAt: molliePayment.createdAt,
-        sctmRequest: JSON.stringify({
+        sctm_id: uuid,
+        sctm_action_type: ConnectorActions.CreatePayment,
+        sctm_created_at: molliePayment.createdAt,
+        sctm_request: JSON.stringify({
           transactionId: CTPayment.transactions[0].id,
           paymentMethod: CTPayment.paymentMethodInfo.method,
         }),
-        sctmResponse: JSON.stringify({
+        sctm_response: JSON.stringify({
           molliePaymentId: molliePayment.id,
           checkoutUrl: molliePayment._links.checkout?.href,
           transactionId: CTPayment.transactions[0].id,
@@ -660,11 +660,11 @@ describe('Test handleCreatePayment', () => {
         action: 'addInterfaceInteraction',
         type: { key: 'sctm_interface_interaction_type' },
         fields: {
-          sctmId: '5c8b0375-305a-4f19-ae8e-07806b101999',
-          sctmActionType: 'createPayment',
-          sctmCreatedAt: '2024-03-20T09:13:37+00:00',
-          sctmRequest: '{"transactionId":"5c8b0375-305a-4f19-ae8e-07806b101999","paymentMethod":"creditcard"}',
-          sctmResponse:
+          sctm_id: '5c8b0375-305a-4f19-ae8e-07806b101999',
+          sctm_action_type: 'createPayment',
+          sctm_created_at: '2024-03-20T09:13:37+00:00',
+          sctm_request: '{"transactionId":"5c8b0375-305a-4f19-ae8e-07806b101999","paymentMethod":"creditcard"}',
+          sctm_response:
             '{"molliePaymentId":"tr_7UhSN1zuXS","checkoutUrl":"https://www.mollie.com/checkout/select-method/7UhSN1zuXS","transactionId":"5c8b0375-305a-4f19-ae8e-07806b101999"}',
         },
       },
@@ -749,11 +749,11 @@ describe('Test handleCreatePayment', () => {
         action: 'addInterfaceInteraction',
         type: { key: 'sctm_interface_interaction_type' },
         fields: {
-          sctmId: '5c8b0375-305a-4f19-ae8e-07806b101999',
-          sctmActionType: 'createPayment',
-          sctmCreatedAt: '2024-03-20T09:13:37+00:00',
-          sctmRequest: '{"transactionId":"5c8b0375-305a-4f19-ae8e-07806b101999","paymentMethod":"creditcard"}',
-          sctmResponse:
+          sctm_id: '5c8b0375-305a-4f19-ae8e-07806b101999',
+          sctm_action_type: 'createPayment',
+          sctm_created_at: '2024-03-20T09:13:37+00:00',
+          sctm_request: '{"transactionId":"5c8b0375-305a-4f19-ae8e-07806b101999","paymentMethod":"creditcard"}',
+          sctm_response:
             '{"molliePaymentId":"tr_7UhSN1zuXS","checkoutUrl":"https://www.mollie.com/checkout/select-method/7UhSN1zuXS","transactionId":"5c8b0375-305a-4f19-ae8e-07806b101999"}',
         },
       },