RedirectToCheckoutResponse confusion

[evertjanMlbrgn]

Subscription builders use:

\Laravel\Cashier\SubscriptionBuilder\RedirectToCheckoutResponse

FirstPaymentChargeBuilder and
UpdatePaymentMethodBuilder uses:
use Laravel\Cashier\Http\RedirectToCheckoutResponse;

i was trying to redirect users to checkout with a new chargeItem, but this failed over and over, the customer did not have a mandate yet, after some time i saw that i used the wrong RedirectToCheckoutResponse

$item = new ChargeItemBuilder($customerProfile);
$item->unitPrice(money($amount, 'EUR'));
$item->description($description);
$chargeItem = $item->make();

$result = $customerProfile->newCharge()
    ->addItem($chargeItem)
    ->setRedirectUrl(config('cashier.first_payment.redirect_url'))
    ->create();

// Note my IDE, or I, accidentially picked \Laravel\Cashier\SubscriptionBuilder\RedirectToCheckoutResponse, instead of 
// use Laravel\Cashier\Http\RedirectToCheckoutResponse in the following line and my payments at mollie timed out.
if(is_a($result, RedirectToCheckoutResponse::class))
{
    return $result;
} else {
    dump('is not a redirectToCheckoutResponse');
}

This might also have caused the issues this user was having: #154

[sandervanhooft]

Hi @evertjanMlbrgn ,

Thanks for reaching out. What's your question or suggestion here?

[evertjanMlbrgn]

It's easy to confuse the 2 types of ther RedirectToCheckoutResponse. Looking at the code i can see that the RedirectToCheckoutResponse in the namespace Laravel\Cashier\SubscriptionBuilder; is an extended version of the one in namespace Laravel\Cashier\Http;

For example the forPayment method is shared by both, but the context is only set for the one for the SubscriptionBuilder. I would suggest 2 different class names for the 2 RedirectToCheckoutResponse classes, maybe let the subscription one extend the Http's one? But i'm not as familiar with the code as you are :-)