handlePaymentPaid might schedule new order items in the past

[sander3]

#220

This just bit me, but if you're offering SEPA Direct Debit as a payment method to your customers you could end up with a resumed subscription + a duplicate payment for the last cycle.

scheduleNewOrderItemAt gets called with the subscription's ends_at timestamp, which might be in the past for people that cancelled while having a "open" payment.

[sandervanhooft]

Hi @sander3 ,

Can you share a code sample so I can reproduce the issue here

[sander3]

There's no code to share but these are the steps to reproduce the issue:

1. Create a subscription using SEPA Direct Debit (using the MandatedSubscriptionBuilder for example).
2. Wait until the first cycle is billed (a Mollie payment with the status open should be created)
3. Cancel the subscription (using cancelNow)
4. Wait until the payment status changes to paid
5. A webhook triggers the handlePaymentPaid method
6. handlePaymentPaid calls scheduleNewOrderItemAt with the subscription's ends_at timestamp (which is in the past) scheduling a new order item that will be immediately billed on the next cashier:run call.

[sandervanhooft]

Thanks @sander3,

I am investigating this issue. The issue seems to be that Cashier v2 is unaware as to why a subscription was canceled, and then cannot distinguish how to handle new payments on an already canceled subscription. I'll keep an eye on fixing this on v3, but it's not something we can fix on v2 without a breaking change.

[ignaciocunado]

I believe this may also happen when a subscription payment fails when a bank declines the payment for some reason. Asking the customer to add a new payment method and doing $order->retryNow(); will also cause this.