fixed and deprecated payment.isRefundable

janpaepke · janpaepke · commit 57d84beea944 · 2025-01-27T12:19:12.000+01:00
diff --git a/src/data/payments/PaymentHelper.ts b/src/data/payments/PaymentHelper.ts
@@ -30,9 +30,10 @@ export default class PaymentHelper extends Helper<PaymentData, Payment> {
    * Returns whether the payment is refundable.
    *
    * @since 2.0.0-rc.2
+   * @deprecated Use `canBeRefunded` instead.
    */
   public isRefundable(this: PaymentData): boolean {
-    return this.amountRemaining !== null;
+    return this.amountRemaining != undefined;
   }
 
   /**

Original file line number	Diff line number	Diff line change
`@@ -30,9 +30,10 @@ export default class PaymentHelper extends Helper<PaymentData, Payment> {`
`30`	`30`	`* Returns whether the payment is refundable.`
`31`	`31`	`*`
`32`	`32`	`* @since 2.0.0-rc.2`
	`33`	+ * @deprecated Use `canBeRefunded` instead.
`33`	`34`	`*/`
`34`	`35`	`public isRefundable(this: PaymentData): boolean {`
`35`		`- return this.amountRemaining !== null;`
	`36`	`+ return this.amountRemaining != undefined;`
`36`	`37`	`}`
`37`	`38`
`38`	`39`	`/**`